Re: [PATCH 06/12] drm/xe/reg_whitelist: Report whitelist overflow using structured xe_log API

[Dnyaneshwar Bhadane <dnyaneshwar.bhadane@Intel.com>]

On 26-Aug-26 3:52 PM, Mallesh, Koujalagi wrote:
> 
> On 20-08-2026 12:44 am, Dnyaneshwar Bhadane wrote:
>> Replace xe_gt_err() with xe_log_err() using the REGS component tag
>> when the maximum register whitelist slots are exhausted.
>>
>> Signed-off-by: Dnyaneshwar Bhadane <dnyaneshwar.bhadane@intel.com>
>> ---
>>   drivers/gpu/drm/xe/xe_reg_whitelist.c | 7 ++++---
>>   1 file changed, 4 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/xe/xe_reg_whitelist.c b/drivers/gpu/drm/ 
>> xe/xe_reg_whitelist.c
>> index cab1b578ca0e..d58c31b30199 100644
>> --- a/drivers/gpu/drm/xe/xe_reg_whitelist.c
>> +++ b/drivers/gpu/drm/xe/xe_reg_whitelist.c
>> @@ -14,6 +14,7 @@
>>   #include "xe_gt.h"
>>   #include "xe_gt_types.h"
>>   #include "xe_gt_printk.h"
>> +#include "xe_log.h"
>>   #include "xe_platform_types.h"
>>   #include "xe_reg_sr.h"
>>   #include "xe_rtp.h"
>> @@ -186,9 +187,9 @@ static int whitelist_apply_to_hwe(struct 
>> xe_hw_engine *hwe, struct xe_reg_sr *in
>>           };
>>           if (slot == RING_MAX_NONPRIV_SLOTS) {
>> -            xe_gt_err(hwe->gt,
>> -                  "hwe %s: maximum register whitelist slots (%d) 
>> reached, refusing to add more\n",
>> -                  hwe->name, RING_MAX_NONPRIV_SLOTS);
>> +            xe_log_err(hwe->gt, REGS, EPERM,
> 
> nit: xe_log takes negative error number. Errno should be -EOVERFLOW right?
This is good suggestion. I will update with -EOVERFLOW in next revision.
Thank you. >
> Thanks,
> 
> -/Mallesh
> 
>> +                   "hwe %s: maximum register whitelist slots (%d) 
>> reached, refusing to add more\n",
>> +                   hwe->name, RING_MAX_NONPRIV_SLOTS);
>>               break;
>>           }