Re: [PATCH 03/12] drm/xe/hwmon: Report errors using structured xe_log API

["Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2095 bytes --]


On 20-08-2026 12:44 am, Dnyaneshwar Bhadane wrote:
> Replace drm_err() calls with xe_log_err() using the HWMON component
> tag to enable structured error reporting with SIGID for hardware
> monitor failures:
nit: '.' rigtht?
>
> Signed-off-by: Dnyaneshwar Bhadane<dnyaneshwar.bhadane@intel.com>
> ---
>   drivers/gpu/drm/xe/xe_hwmon.c | 10 ++++++----
>   1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_hwmon.c b/drivers/gpu/drm/xe/xe_hwmon.c
> index 5284cab6703d..9ff351e87e5a 100644
> --- a/drivers/gpu/drm/xe/xe_hwmon.c
> +++ b/drivers/gpu/drm/xe/xe_hwmon.c
> @@ -15,6 +15,7 @@
>   #include "regs/xe_pcode_regs.h"
>   #include "xe_device.h"
>   #include "xe_hwmon.h"
> +#include "xe_log.h"
>   #include "xe_mmio.h"
>   #include "xe_pcode.h"
>   #include "xe_pcode_api.h"
> @@ -563,9 +564,9 @@ xe_hwmon_power_max_interval_show(struct device *dev, struct device_attribute *at
>   	if (hwmon->xe->info.has_mbx_power_limits) {
>   		ret = xe_hwmon_pcode_read_power_limit(hwmon, power_attr, channel, &reg_val);
>   		if (ret) {
> -			drm_err(&hwmon->xe->drm,
> -				"power interval read fail, ch %d, attr %d, val 0x%08x, ret %d\n",
> -				channel, power_attr, reg_val, ret);
> +			xe_log_err(hwmon->xe, HWMON, -EIO,
Use ret as errno.
> +				   "power interval read fail, ch %d, attr %d, val 0x%08x, ret %d\n",
> +				   channel, power_attr, reg_val, ret);
Once you pass ret as errno, no need to log it.
>   			reg_val = 0;
>   		}
>   	} else {
> @@ -1599,7 +1600,8 @@ int xe_hwmon_register(struct xe_device *xe)
>   								&hwmon_chip_info,
>   								hwmon_groups);
>   	if (IS_ERR(hwmon->hwmon_dev)) {
> -		drm_err(&xe->drm, "Failed to register xe hwmon (%pe)\n", hwmon->hwmon_dev);
> +		xe_log_err(xe, HWMON, -EIO,
hmm, is -EIO correct one?  we can use PTR_ERR(hwmon->hwmon_dev) right?
> +			   "Failed to register xe hwmon (%pe)", hwmon->hwmon_dev);

nit: Once we pass correct errno, no need to log so remove hwmon->hwmon_dev.

nit: add '\n' end of message


Thanks,

-/Mallesh

>   		xe->hwmon = NULL;
>   		return PTR_ERR(hwmon->hwmon_dev);
>   	}

[-- Attachment #2: Type: text/html, Size: 3547 bytes --]