From: Nirmoy Das <nirmoy.das@linux.intel.com>
To: Dafna Hirschfeld <dhirschfeld@habana.ai>, intel-xe@lists.freedesktop.org
Cc: matthew.brost@intel.com
Subject: Re: [PATCH] drm/xe: fix missing 'xe_vm_put'
Date: Mon, 2 Sep 2024 17:04:58 +0200 [thread overview]
Message-ID: <6c905752-e7ea-42ee-9a62-5bda06a38a32@linux.intel.com> (raw)
In-Reply-To: <20240901044227.1177211-1-dhirschfeld@habana.ai>
On 9/1/2024 6:42 AM, Dafna Hirschfeld wrote:
> Fix memleak caused by missing xe_vm_put
>
> Signed-off-by: Dafna Hirschfeld <dhirschfeld@habana.ai>
Fixes: 852856e3b6f6 ("drm/xe: Use reserved copy engine for user binds on
faulting devices")
Reviewed-by: Nirmoy Das <nirmoy.das@intel.com>
> ---
> drivers/gpu/drm/xe/xe_exec_queue.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_exec_queue.c b/drivers/gpu/drm/xe/xe_exec_queue.c
> index fa4ed168b53b..df3ea337f55c 100644
> --- a/drivers/gpu/drm/xe/xe_exec_queue.c
> +++ b/drivers/gpu/drm/xe/xe_exec_queue.c
> @@ -252,8 +252,10 @@ struct xe_exec_queue *xe_exec_queue_create_bind(struct xe_device *xe,
> gt->usm.reserved_bcs_instance,
> false);
>
> - if (!hwe)
> + if (!hwe) {
> + xe_vm_put(migrate_vm);
> return ERR_PTR(-EINVAL);
> + }
>
> q = xe_exec_queue_create(xe, migrate_vm,
> BIT(hwe->logical_instance), 1, hwe,
prev parent reply other threads:[~2024-09-02 15:05 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-01 4:42 [PATCH] drm/xe: fix missing 'xe_vm_put' Dafna Hirschfeld
2024-09-01 4:49 ` ✓ CI.Patch_applied: success for " Patchwork
2024-09-01 4:49 ` ✓ CI.checkpatch: " Patchwork
2024-09-01 4:50 ` ✓ CI.KUnit: " Patchwork
2024-09-01 5:02 ` ✓ CI.Build: " Patchwork
2024-09-01 5:04 ` ✓ CI.Hooks: " Patchwork
2024-09-01 5:06 ` ✓ CI.checksparse: " Patchwork
2024-09-01 5:25 ` ✓ CI.BAT: " Patchwork
2024-09-01 6:26 ` ✗ CI.FULL: failure " Patchwork
2024-09-02 15:04 ` Nirmoy Das [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c905752-e7ea-42ee-9a62-5bda06a38a32@linux.intel.com \
--to=nirmoy.das@linux.intel.com \
--cc=dhirschfeld@habana.ai \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox