Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: fix missing 'xe_vm_put'
@ 2024-09-01  4:42 Dafna Hirschfeld
  2024-09-01  4:49 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: Dafna Hirschfeld @ 2024-09-01  4:42 UTC (permalink / raw)
  To: intel-xe; +Cc: matthew.brost, Dafna Hirschfeld

Fix memleak caused by missing xe_vm_put

Signed-off-by: Dafna Hirschfeld <dhirschfeld@habana.ai>
---
 drivers/gpu/drm/xe/xe_exec_queue.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_exec_queue.c b/drivers/gpu/drm/xe/xe_exec_queue.c
index fa4ed168b53b..df3ea337f55c 100644
--- a/drivers/gpu/drm/xe/xe_exec_queue.c
+++ b/drivers/gpu/drm/xe/xe_exec_queue.c
@@ -252,8 +252,10 @@ struct xe_exec_queue *xe_exec_queue_create_bind(struct xe_device *xe,
 							   gt->usm.reserved_bcs_instance,
 							   false);
 
-		if (!hwe)
+		if (!hwe) {
+			xe_vm_put(migrate_vm);
 			return ERR_PTR(-EINVAL);
+		}
 
 		q = xe_exec_queue_create(xe, migrate_vm,
 					 BIT(hwe->logical_instance), 1, hwe,
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2024-09-02 15:05 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-01  4:42 [PATCH] drm/xe: fix missing 'xe_vm_put' Dafna Hirschfeld
2024-09-01  4:49 ` ✓ CI.Patch_applied: success for " Patchwork
2024-09-01  4:49 ` ✓ CI.checkpatch: " Patchwork
2024-09-01  4:50 ` ✓ CI.KUnit: " Patchwork
2024-09-01  5:02 ` ✓ CI.Build: " Patchwork
2024-09-01  5:04 ` ✓ CI.Hooks: " Patchwork
2024-09-01  5:06 ` ✓ CI.checksparse: " Patchwork
2024-09-01  5:25 ` ✓ CI.BAT: " Patchwork
2024-09-01  6:26 ` ✗ CI.FULL: failure " Patchwork
2024-09-02 15:04 ` [PATCH] " Nirmoy Das

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox