From: "Souza, Jose" <jose.souza@intel.com>
To: "juhapekka.heikkila@gmail.com" <juhapekka.heikkila@gmail.com>,
"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Cc: "jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>
Subject: Re: [PATCH] drm/i915/display: Disable AuxCCS framebuffers if built for Xe
Date: Thu, 29 Feb 2024 16:44:48 +0000 [thread overview]
Message-ID: <70165ba67dc882f9171fdc9d6807f0cd60ebfe19.camel@intel.com> (raw)
In-Reply-To: <1dcc4bc35070f9da7f3f275e2765edb8f9a20e3c.camel@intel.com>
On Wed, 2024-02-28 at 06:04 -0800, José Roberto de Souza wrote:
> On Wed, 2024-02-28 at 16:02 +0200, Juha-Pekka Heikkila wrote:
> > AuxCCS framebuffers don't work on Xe driver hence disable them
> > from plane capabilities until they are fixed. FlatCCS framebuffers
> > work and they are left enabled. CCS is left untouched for i915
> > driver.
> >
>
> Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
This needs a Fixes tag so it gets backported to Linux 6.8.
>
> > Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/933
> > Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> > ---
> > drivers/gpu/drm/i915/display/skl_universal_plane.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > index e941e2e4fd14..860574d04f88 100644
> > --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> > @@ -2295,6 +2295,9 @@ static u8 skl_get_plane_caps(struct drm_i915_private *i915,
> > if (HAS_4TILE(i915))
> > caps |= INTEL_PLANE_CAP_TILING_4;
> >
> > + if (!IS_ENABLED(I915) && !HAS_FLAT_CCS(i915))
> > + return caps;
> > +
> > if (skl_plane_has_rc_ccs(i915, pipe, plane_id)) {
> > caps |= INTEL_PLANE_CAP_CCS_RC;
> > if (DISPLAY_VER(i915) >= 12)
>
next prev parent reply other threads:[~2024-02-29 16:45 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-28 14:02 [PATCH] drm/i915/display: Disable AuxCCS framebuffers if built for Xe Juha-Pekka Heikkila
2024-02-28 14:04 ` Souza, Jose
2024-02-29 16:44 ` Souza, Jose [this message]
2024-02-29 17:36 ` Souza, Jose
2024-02-28 14:07 ` ✓ CI.Patch_applied: success for drm/i915/display: Disable AuxCCS framebuffers if built for Xe (rev2) Patchwork
2024-02-28 14:07 ` ✗ CI.checkpatch: warning " Patchwork
2024-02-28 14:08 ` ✓ CI.KUnit: success " Patchwork
2024-02-28 14:26 ` ✓ CI.Build: " Patchwork
2024-02-28 14:27 ` ✓ CI.Hooks: " Patchwork
2024-02-28 14:28 ` ✗ CI.checksparse: warning " Patchwork
2024-02-28 15:03 ` ✓ CI.BAT: success " Patchwork
2024-03-05 16:44 ` [PATCH] drm/i915/display: Disable AuxCCS framebuffers if built for Xe Jani Nikula
2025-01-28 13:08 ` Tvrtko Ursulin
2025-01-28 15:55 ` Juha-Pekka Heikkilä
2025-01-29 8:44 ` Tvrtko Ursulin
2025-01-29 15:20 ` Juha-Pekka Heikkilä
2024-03-06 13:57 ` Souza, Jose
-- strict thread matches above, loose matches on Subject: below --
2024-02-26 20:36 Juha-Pekka Heikkila
2024-02-27 8:57 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=70165ba67dc882f9171fdc9d6807f0cd60ebfe19.camel@intel.com \
--to=jose.souza@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=juhapekka.heikkila@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox