Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Souza, Jose" <jose.souza@intel.com>
To: "juhapekka.heikkila@gmail.com" <juhapekka.heikkila@gmail.com>,
	"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH] drm/i915/display: Disable AuxCCS framebuffers if built for Xe
Date: Wed, 6 Mar 2024 13:57:56 +0000	[thread overview]
Message-ID: <e12082da5c52d6fc303ca9a77b93dd2d2e976229.camel@intel.com> (raw)
In-Reply-To: <20240228140225.858145-1-juhapekka.heikkila@gmail.com>

On Wed, 2024-02-28 at 16:02 +0200, Juha-Pekka Heikkila wrote:
> AuxCCS framebuffers don't work on Xe driver hence disable them
> from plane capabilities until they are fixed. FlatCCS framebuffers
> work and they are left enabled. CCS is left untouched for i915
> driver.
> 

Fixes: 44e694958b95 ("drm/xe/display: Implement display support")

> Closes: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/933
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
>  drivers/gpu/drm/i915/display/skl_universal_plane.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> index e941e2e4fd14..860574d04f88 100644
> --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> @@ -2295,6 +2295,9 @@ static u8 skl_get_plane_caps(struct drm_i915_private *i915,
>  	if (HAS_4TILE(i915))
>  		caps |= INTEL_PLANE_CAP_TILING_4;
>  
> +	if (!IS_ENABLED(I915) && !HAS_FLAT_CCS(i915))
> +		return caps;
> +
>  	if (skl_plane_has_rc_ccs(i915, pipe, plane_id)) {
>  		caps |= INTEL_PLANE_CAP_CCS_RC;
>  		if (DISPLAY_VER(i915) >= 12)


  parent reply	other threads:[~2024-03-06 13:58 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-28 14:02 [PATCH] drm/i915/display: Disable AuxCCS framebuffers if built for Xe Juha-Pekka Heikkila
2024-02-28 14:04 ` Souza, Jose
2024-02-29 16:44   ` Souza, Jose
2024-02-29 17:36     ` Souza, Jose
2024-02-28 14:07 ` ✓ CI.Patch_applied: success for drm/i915/display: Disable AuxCCS framebuffers if built for Xe (rev2) Patchwork
2024-02-28 14:07 ` ✗ CI.checkpatch: warning " Patchwork
2024-02-28 14:08 ` ✓ CI.KUnit: success " Patchwork
2024-02-28 14:26 ` ✓ CI.Build: " Patchwork
2024-02-28 14:27 ` ✓ CI.Hooks: " Patchwork
2024-02-28 14:28 ` ✗ CI.checksparse: warning " Patchwork
2024-02-28 15:03 ` ✓ CI.BAT: success " Patchwork
2024-03-05 16:44 ` [PATCH] drm/i915/display: Disable AuxCCS framebuffers if built for Xe Jani Nikula
2025-01-28 13:08   ` Tvrtko Ursulin
2025-01-28 15:55     ` Juha-Pekka Heikkilä
2025-01-29  8:44       ` Tvrtko Ursulin
2025-01-29 15:20         ` Juha-Pekka Heikkilä
2024-03-06 13:57 ` Souza, Jose [this message]
  -- strict thread matches above, loose matches on Subject: below --
2024-02-26 20:36 Juha-Pekka Heikkila
2024-02-27  8:57 ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e12082da5c52d6fc303ca9a77b93dd2d2e976229.camel@intel.com \
    --to=jose.souza@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=juhapekka.heikkila@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox