Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: jani.nikula@intel.com, ville.syrjala@linux.intel.com
Subject: [PATCH 5/6] drm/i915/irq: change ILK irq handling order
Date: Fri, 19 Sep 2025 12:51:48 +0300	[thread overview]
Message-ID: <76190090bb64597359802dfdf0e925fe478cd0d5.1758275448.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1758275448.git.jani.nikula@intel.com>

Handle GEN6_PMIIR before DEIIR. This allows us to further refactor
display irq handling, but separate this change to give us a clean bisect
landing commit for the unlikely case that this makes a difference.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/i915_irq.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 90174ce9195c..312f7e42931a 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_irq.c
@@ -449,6 +449,15 @@ static irqreturn_t ilk_irq_handler(int irq, void *arg)
 		ret = IRQ_HANDLED;
 	}
 
+	if (GRAPHICS_VER(i915) >= 6) {
+		u32 pm_iir = raw_reg_read(regs, GEN6_PMIIR);
+		if (pm_iir) {
+			raw_reg_write(regs, GEN6_PMIIR, pm_iir);
+			gen6_rps_irq_handler(&to_gt(i915)->rps, pm_iir);
+			ret = IRQ_HANDLED;
+		}
+	}
+
 	de_iir = raw_reg_read(regs, DEIIR);
 	if (de_iir) {
 		raw_reg_write(regs, DEIIR, de_iir);
@@ -459,15 +468,6 @@ static irqreturn_t ilk_irq_handler(int irq, void *arg)
 		ret = IRQ_HANDLED;
 	}
 
-	if (GRAPHICS_VER(i915) >= 6) {
-		u32 pm_iir = raw_reg_read(regs, GEN6_PMIIR);
-		if (pm_iir) {
-			raw_reg_write(regs, GEN6_PMIIR, pm_iir);
-			gen6_rps_irq_handler(&to_gt(i915)->rps, pm_iir);
-			ret = IRQ_HANDLED;
-		}
-	}
-
 	raw_reg_write(regs, DEIER, de_ier);
 	if (sde_ier)
 		raw_reg_write(regs, SDEIER, sde_ier);
-- 
2.47.3


  parent reply	other threads:[~2025-09-19  9:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-19  9:51 [PATCH 0/6] drm/i915/irq: display irq refactoring Jani Nikula
2025-09-19  9:51 ` [PATCH 1/6] drm/i915/irq: drop intel_psr_regs.h include Jani Nikula
2025-09-19  9:51 ` [PATCH 2/6] drm/i915/irq: initialize gen2_imr_mask in terms of enable_mask Jani Nikula
2025-09-19  9:51 ` [PATCH 3/6] drm/i915/irq: abstract i9xx_display_irq_enable_mask() Jani Nikula
2025-09-19  9:51 ` [PATCH 4/6] drm/i915/irq: move check for HAS_HOTPLUG() inside i9xx_hpd_irq_ack() Jani Nikula
2025-09-19  9:51 ` Jani Nikula [this message]
2025-09-19  9:51 ` [PATCH 6/6] drm/i915/irq: split ILK display irq handling Jani Nikula
2025-09-19 12:10   ` Ville Syrjälä
2025-09-23 14:15     ` Jani Nikula
2025-09-19 12:23   ` Ville Syrjälä
2025-09-23 14:17     ` Jani Nikula
2025-09-19  9:58 ` ✗ CI.checkpatch: warning for drm/i915/irq: display irq refactoring Patchwork
2025-09-19  9:59 ` ✓ CI.KUnit: success " Patchwork
2025-09-19 18:42 ` ✗ Xe.CI.Full: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76190090bb64597359802dfdf0e925fe478cd0d5.1758275448.git.jani.nikula@intel.com \
    --to=jani.nikula@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox