Re: [PATCH 6/6] drm/i915/irq: split ILK display irq handling

[Jani Nikula <jani.nikula@intel.com>]

On Fri, 19 Sep 2025, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Fri, Sep 19, 2025 at 12:51:49PM +0300, Jani Nikula wrote:
>> +bool ilk_display_irq_handler(struct intel_display *display, u32 de_ier, u32 sde_ier)
>> +{
>> +	u32 de_iir;
>> +	bool handled = false;
>> +
>> +	de_iir = intel_de_read(display, DEIIR);
>> +	if (de_iir) {
>> +		intel_de_write(display, DEIIR, de_iir);
>> +		if (DISPLAY_VER(display) >= 7)
>> +			_ivb_display_irq_handler(display, de_iir);
>> +		else
>> +			_ilk_display_irq_handler(display, de_iir);
>> +		handled = true;
>> +	}
>> +
>> +	intel_de_write(display, DEIER, de_ier);
>> +
>> +	if (sde_ier)
>> +		intel_de_write(display, SDEIER, sde_ier);
>
> Maybe the re-enable should be its own function just to make
> things a bit less confusing?

With that I can actually drop patch 5/6.

BR,
Jani.


-- 
Jani Nikula, Intel