Re: [PATCH 1/2] drm/dp: Add definition for Panel Replay full-line granularity

[Maarten Lankhorst <maarten.lankhorst@linux.intel.com>]

Hey,

Den 2026-02-27 kl. 06:49, skrev Hogander, Jouni:
> On Thu, 2026-02-26 at 21:02 +0000, Shankar, Uma wrote:
>>
>>
>>> -----Original Message-----
>>> From: Intel-xe <intel-xe-bounces@lists.freedesktop.org> On Behalf
>>> Of Jouni
>>> Högander
>>> Sent: Wednesday, February 25, 2026 1:12 PM
>>> To: intel-gfx@lists.freedesktop.org; intel-xe@lists.freedesktop.org
>>> Cc: Hogander, Jouni <jouni.hogander@intel.com>;
>>> dri-devel@lists.freedesktop.org
>>> Subject: [PATCH 1/2] drm/dp: Add definition for Panel Replay full-
>>> line granularity
>>>
>>> DP specification is saying value 0xff 0xff in PANEL REPLAY
>>> SELECTIVE
>>> UPDATE X GRANULARITY CAPABILITY registers (0xb2 and 0xb3) means
>>> full-
>>> line granularity. Add definition for this.
>>
>> I think it would be good to call this also out also in comment:
>> "The SU region width shall be equal to the horizontal width of the
>> timing being transported"
>> This clarifies what is meant by full line granularity here.
> 
> I will add this comment.
> 
>>
>>>
>>> Cc: dri-devel@lists.freedesktop.org
>>> Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
>>> ---
>>>  include/drm/display/drm_dp.h | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/include/drm/display/drm_dp.h
>>> b/include/drm/display/drm_dp.h index
>>> e4eebabab975..8b15d3eeb716 100644
>>> --- a/include/drm/display/drm_dp.h
>>> +++ b/include/drm/display/drm_dp.h
>>> @@ -571,6 +571,8 @@
>>>  # define
>>> DP_PANEL_REPLAY_LINK_OFF_SUPPORTED_IN_PR_AFTER_ADAPTIVE_SYN
>>> C_SDP	(1 << 7)
>>>
>>>  #define DP_PANEL_REPLAY_CAP_X_GRANULARITY		0xb2
>>> +# define DP_PANEL_REPLAY_FULL_LINE_GRANULARITY		0xffff
>>
>> Space in #define can be removed.
> 
> I followed convention used elsewhere in drm_dp.h. I.e. register field
> definitions have this extra space. What do you think?
> 
> BR,
> Jouni Högander
Seems to be the convention here, so fine with me.

For merging through drm-intel:
Acked-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>

>>
>> With above fixed, Change looks good to me.
>> Reviewed-by: Uma Shankar <uma.shankar@intel.com>
>>
>>>  #define DP_PANEL_REPLAY_CAP_Y_GRANULARITY		0xb4
>>>
>>>  /* Link Configuration */
>>> --
>>> 2.43.0
>>
>