Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v1] drm/xe: avoid the async_flip update in the initial plane config
@ 2024-04-19 14:09 Vinod Govindapillai
  2024-04-19 17:56 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (16 more replies)
  0 siblings, 17 replies; 20+ messages in thread
From: Vinod Govindapillai @ 2024-04-19 14:09 UTC (permalink / raw)
  To: intel-xe, intel-gfx; +Cc: vinod.govindapillai, ville.syrjala, matthew.d.roper

Async flip call is not needed. The updated fb mapping is updated
as part of the fixup_initial_plane_config() call. Otherwise we
end up updating the PLAN_SURF register twice with the same info.

v2: avoid async_flip instead of removing fixup call (Ville)

Signed-off-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
---
 drivers/gpu/drm/xe/display/xe_plane_initial.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/drivers/gpu/drm/xe/display/xe_plane_initial.c b/drivers/gpu/drm/xe/display/xe_plane_initial.c
index 9693c56d386b..b5f8381b593d 100644
--- a/drivers/gpu/drm/xe/display/xe_plane_initial.c
+++ b/drivers/gpu/drm/xe/display/xe_plane_initial.c
@@ -189,8 +189,6 @@ intel_find_initial_plane_obj(struct intel_crtc *crtc,
 		to_intel_plane(crtc->base.primary);
 	struct intel_plane_state *plane_state =
 		to_intel_plane_state(plane->base.state);
-	struct intel_crtc_state *crtc_state =
-		to_intel_crtc_state(crtc->base.state);
 	struct drm_framebuffer *fb;
 	struct i915_vma *vma;
 
@@ -236,14 +234,6 @@ intel_find_initial_plane_obj(struct intel_crtc *crtc,
 	atomic_or(plane->frontbuffer_bit, &to_intel_frontbuffer(fb)->bits);
 
 	plane_config->vma = vma;
-
-	/*
-	 * Flip to the newly created mapping ASAP, so we can re-use the
-	 * first part of GGTT for WOPCM, prevent flickering, and prevent
-	 * the lookup of sysmem scratch pages.
-	 */
-	plane->check_plane(crtc_state, plane_state);
-	plane->async_flip(plane, crtc_state, plane_state, true);
 	return;
 
 nofb:
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2024-06-14  8:41 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-19 14:09 [PATCH v1] drm/xe: avoid the async_flip update in the initial plane config Vinod Govindapillai
2024-04-19 17:56 ` ✓ CI.Patch_applied: success for " Patchwork
2024-04-19 17:57 ` ✓ CI.checkpatch: " Patchwork
2024-04-19 17:57 ` ✓ CI.KUnit: " Patchwork
2024-04-19 18:09 ` ✓ CI.Build: " Patchwork
2024-04-19 18:16 ` ✓ CI.Hooks: " Patchwork
2024-04-19 18:23 ` ✓ CI.checksparse: " Patchwork
2024-04-19 19:30 ` ✗ CI.BAT: failure " Patchwork
2024-04-21 10:57 ` ✗ CI.FULL: " Patchwork
2024-04-23 12:07 ` ✓ CI.Patch_applied: success for drm/xe: avoid the async_flip update in the initial plane config (rev2) Patchwork
2024-04-23 12:07 ` ✓ CI.checkpatch: " Patchwork
2024-04-23 12:08 ` ✓ CI.KUnit: " Patchwork
2024-04-23 12:26 ` ✓ CI.Build: " Patchwork
2024-04-23 12:29 ` ✓ CI.Hooks: " Patchwork
2024-04-23 12:31 ` ✓ CI.checksparse: " Patchwork
2024-04-23 12:54 ` ✓ CI.BAT: " Patchwork
2024-04-23 19:15 ` ✓ CI.FULL: " Patchwork
2024-06-14  7:11 ` [PATCH v1] drm/xe: avoid the async_flip update in the initial plane config Hogander, Jouni
2024-06-14  8:23   ` Govindapillai, Vinod
2024-06-14  8:41     ` Hogander, Jouni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox