Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Set PTE_AE for xe2 dgfx platforms
@ 2024-01-17 14:48 Nirmoy Das
  2024-01-17 23:48 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (13 more replies)
  0 siblings, 14 replies; 18+ messages in thread
From: Nirmoy Das @ 2024-01-17 14:48 UTC (permalink / raw)
  To: intel-xe; +Cc: Matt Roper, Nirmoy Das

Atomics on XE2 works for both type of memory so
extend setting PTE_AE for dgfx platforms as well.

Cc: Fei Yang <fei.yang@intel.com>
Cc: Jose Souza <jose.souza@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Brian Welty <brian.welty@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 drivers/gpu/drm/xe/xe_pt.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_pt.c b/drivers/gpu/drm/xe/xe_pt.c
index de1030a47588..3ace4b401369 100644
--- a/drivers/gpu/drm/xe/xe_pt.c
+++ b/drivers/gpu/drm/xe/xe_pt.c
@@ -602,8 +602,12 @@ xe_pt_stage_bind(struct xe_tile *tile, struct xe_vma *vma,
 	struct xe_pt *pt = xe_vma_vm(vma)->pt_root[tile->id];
 	int ret;
 
+	/**
+	 * XE_USM_PPGTT_PTE_AE is available for igfx and dgfx from xe2 onwards
+	 * and also for PVC but atomics only works for PVC on device memory.
+	 */
 	if (vma && (vma->gpuva.flags & XE_VMA_ATOMIC_PTE_BIT) &&
-	    (is_devmem || !IS_DGFX(xe)))
+	    (is_devmem || GRAPHICS_VER(xe) >= 20))
 		xe_walk.default_pte |= XE_USM_PPGTT_PTE_AE;
 
 	if (is_devmem) {
-- 
2.42.0


^ permalink raw reply related	[flat|nested] 18+ messages in thread
end of thread, other threads:[~2024-01-19 10:18 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-17 14:48 [PATCH] drm/xe: Set PTE_AE for xe2 dgfx platforms Nirmoy Das
2024-01-17 23:48 ` ✓ CI.Patch_applied: success for " Patchwork
2024-01-17 23:48 ` ✓ CI.checkpatch: " Patchwork
2024-01-17 23:49 ` ✓ CI.KUnit: " Patchwork
2024-01-17 23:56 ` ✓ CI.Build: " Patchwork
2024-01-17 23:57 ` ✓ CI.Hooks: " Patchwork
2024-01-17 23:58 ` ✓ CI.checksparse: " Patchwork
2024-01-18  0:49 ` [PATCH] " Matt Roper
2024-01-18 14:42   ` Nirmoy Das
2024-01-18 16:08     ` Matt Roper
2024-01-19 10:18       ` Nirmoy Das
2024-01-18  5:52 ` ✓ CI.Patch_applied: success for drm/xe: Set PTE_AE for xe2 dgfx platforms (rev2) Patchwork
2024-01-18  5:52 ` ✓ CI.checkpatch: " Patchwork
2024-01-18  5:53 ` ✓ CI.KUnit: " Patchwork
2024-01-18  6:00 ` ✓ CI.Build: " Patchwork
2024-01-18  6:00 ` ✓ CI.Hooks: " Patchwork
2024-01-18  6:01 ` ✓ CI.checksparse: " Patchwork
2024-01-18  6:25 ` ✓ CI.BAT: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox