Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Don't restart parallel queues multiple times on GT reset
@ 2024-10-21 21:11 Nirmoy Das
  2024-10-21 22:26 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (9 more replies)
  0 siblings, 10 replies; 13+ messages in thread
From: Nirmoy Das @ 2024-10-21 21:11 UTC (permalink / raw)
  To: intel-xe
  Cc: Nirmoy Das, Himal Prasad Ghimiray, Matthew Auld, Matthew Brost,
	Tejas Upadhyay

In case of parallel submissions multiple GuC id will point to the
same exec queue and on GT reset such exec queues will get restarted
multiple times which is not desirable.

Link: https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/2295
Cc: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Matthew Brost <matthew.brost@intel.com>
Cc: Tejas Upadhyay <tejas.upadhyay@intel.com>
Signed-off-by: Nirmoy Das <nirmoy.das@intel.com>
---
 drivers/gpu/drm/xe/xe_guc_submit.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/xe/xe_guc_submit.c b/drivers/gpu/drm/xe/xe_guc_submit.c
index 0b81972ff651..6aeb007eaf06 100644
--- a/drivers/gpu/drm/xe/xe_guc_submit.c
+++ b/drivers/gpu/drm/xe/xe_guc_submit.c
@@ -1784,8 +1784,13 @@ int xe_guc_submit_start(struct xe_guc *guc)
 
 	mutex_lock(&guc->submission_state.lock);
 	atomic_dec(&guc->submission_state.stopped);
-	xa_for_each(&guc->submission_state.exec_queue_lookup, index, q)
+	xa_for_each(&guc->submission_state.exec_queue_lookup, index, q) {
+		/* Skip restarting parallel queues */
+		if (exec_queue_enabled(q) && xe_exec_queue_is_parallel(q))
+			continue;
+
 		guc_exec_queue_start(q);
+	}
 	mutex_unlock(&guc->submission_state.lock);
 
 	wake_up_all(&guc->ct.wq);
-- 
2.46.0


^ permalink raw reply related	[flat|nested] 13+ messages in thread
end of thread, other threads:[~2024-10-22  7:36 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-21 21:11 [PATCH] drm/xe: Don't restart parallel queues multiple times on GT reset Nirmoy Das
2024-10-21 22:26 ` ✓ CI.Patch_applied: success for " Patchwork
2024-10-21 22:26 ` ✓ CI.checkpatch: " Patchwork
2024-10-21 22:27 ` ✓ CI.KUnit: " Patchwork
2024-10-21 22:28 ` [PATCH] " Cavitt, Jonathan
2024-10-22  7:22   ` Nirmoy Das
2024-10-21 22:38 ` ✓ CI.Build: success for " Patchwork
2024-10-21 22:41 ` ✓ CI.Hooks: " Patchwork
2024-10-21 22:42 ` ✓ CI.checksparse: " Patchwork
2024-10-21 23:01 ` ✓ CI.BAT: " Patchwork
2024-10-21 23:02 ` [PATCH] " Matthew Brost
2024-10-22  7:35   ` Nirmoy Das
2024-10-22  5:40 ` ✗ CI.FULL: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox