Re: [PATCH v12 2/4] drm/xe: Update wedged.mode only after successful reset policy change

["Laguna, Lukasz" <lukasz.laguna@intel.com>]

On 1/18/2026 15:39, Thomas Hellström wrote:
> Hi, Lukasz,
>
> On Wed, 2026-01-07 at 18:47 +0100, Lukasz Laguna wrote:
>> Previously, the driver's internal wedged.mode state was updated
>> without
>> verifying whether the corresponding engine reset policy update in GuC
>> succeeded. This could leave the driver reporting a wedged.mode state
>> that doesn't match the actual reset behavior programmed in GuC.
>>
>> With this change, the reset policy is updated first, and the driver's
>> wedged.mode state is modified only if the policy update succeeds on
>> all
>> available GTs.
>>
>> This patch also introduces two functional improvements:
>>
>>   - The policy is sent to GuC only when a change is required. An
>> update
>>     is needed only when entering or leaving
>> XE_WEDGED_MODE_UPON_ANY_HANG,
>>     because only in that case the reset policy changes. For example,
>>     switching between XE_WEDGED_MODE_UPON_CRITICAL_ERROR and
>>     XE_WEDGED_MODE_NEVER doesn't affect the reset policy, so there is
>> no
>>     need to send the same value to GuC.
>>
>>   - An inconsistent_reset flag is added to track cases where reset
>> policy
>>     update succeeds only on a subset of GTs. If such inconsistency is
>>     detected, future wedged mode configuration will force a retry of
>> the
>>     reset policy update to restore a consistent state across all GTs.
>>
>> Fixes: 6b8ef44cc0a9 ("drm/xe: Introduce the wedged_mode debugfs")
> This patch causes conflicts in the drm-xe-fixes branch that are not
> trivially resolved since it seems to depend on various previous
> patches.
>
> This will likely make backporting also to earlier kernels a pain,
> ("dim fixes 6b8ef44cc0a9" indicates the fixed commit goes back to linux
> 6.11).
>
> Could you please provide a backport of this patch that compiles and
> works with the drm-xe-fixes branch?
>
> Thanks,
> Thomas
>

Hi Thomas,

Yes, I'll prepare a backport.

Regards,
Lukasz