From: "Thomas Hellström" <thomas.hellstrom@linux.intel.com>
To: Lukasz Laguna <lukasz.laguna@intel.com>, intel-xe@lists.freedesktop.org
Cc: michal.wajdeczko@intel.com, rodrigo.vivi@intel.com,
matthew.brost@intel.com
Subject: Re: [PATCH v12 2/4] drm/xe: Update wedged.mode only after successful reset policy change
Date: Sun, 18 Jan 2026 15:39:51 +0100 [thread overview]
Message-ID: <be4475588e406334276f011a11f918ab73f73bd6.camel@linux.intel.com> (raw)
In-Reply-To: <20260107174741.29163-3-lukasz.laguna@intel.com>
Hi, Lukasz,
On Wed, 2026-01-07 at 18:47 +0100, Lukasz Laguna wrote:
> Previously, the driver's internal wedged.mode state was updated
> without
> verifying whether the corresponding engine reset policy update in GuC
> succeeded. This could leave the driver reporting a wedged.mode state
> that doesn't match the actual reset behavior programmed in GuC.
>
> With this change, the reset policy is updated first, and the driver's
> wedged.mode state is modified only if the policy update succeeds on
> all
> available GTs.
>
> This patch also introduces two functional improvements:
>
> - The policy is sent to GuC only when a change is required. An
> update
> is needed only when entering or leaving
> XE_WEDGED_MODE_UPON_ANY_HANG,
> because only in that case the reset policy changes. For example,
> switching between XE_WEDGED_MODE_UPON_CRITICAL_ERROR and
> XE_WEDGED_MODE_NEVER doesn't affect the reset policy, so there is
> no
> need to send the same value to GuC.
>
> - An inconsistent_reset flag is added to track cases where reset
> policy
> update succeeds only on a subset of GTs. If such inconsistency is
> detected, future wedged mode configuration will force a retry of
> the
> reset policy update to restore a consistent state across all GTs.
>
> Fixes: 6b8ef44cc0a9 ("drm/xe: Introduce the wedged_mode debugfs")
This patch causes conflicts in the drm-xe-fixes branch that are not
trivially resolved since it seems to depend on various previous
patches.
This will likely make backporting also to earlier kernels a pain,
("dim fixes 6b8ef44cc0a9" indicates the fixed commit goes back to linux
6.11).
Could you please provide a backport of this patch that compiles and
works with the drm-xe-fixes branch?
Thanks,
Thomas
next prev parent reply other threads:[~2026-01-18 14:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 17:47 [PATCH v12 0/4] drm/xe: Improve wedged mode handling Lukasz Laguna
2026-01-07 17:47 ` [PATCH v12 1/4] drm/xe: Validate wedged_mode parameter and define enum for modes Lukasz Laguna
2026-01-07 17:47 ` [PATCH v12 2/4] drm/xe: Update wedged.mode only after successful reset policy change Lukasz Laguna
2026-01-08 21:06 ` Rodrigo Vivi
2026-01-18 14:39 ` Thomas Hellström [this message]
2026-01-20 8:27 ` Laguna, Lukasz
2026-01-07 17:47 ` [PATCH v12 3/4] drm/xe/vf: Disallow setting wedged mode to upon-any-hang Lukasz Laguna
2026-01-07 17:47 ` [PATCH v12 4/4] drm/xe/pf: Allow upon-any-hang wedged mode only in debug config Lukasz Laguna
2026-01-07 17:55 ` ✓ CI.KUnit: success for drm/xe: Improve wedged mode handling (rev12) Patchwork
2026-01-07 18:33 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-07 19:54 ` ✗ Xe.CI.Full: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=be4475588e406334276f011a11f918ab73f73bd6.camel@linux.intel.com \
--to=thomas.hellstrom@linux.intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lukasz.laguna@intel.com \
--cc=matthew.brost@intel.com \
--cc=michal.wajdeczko@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox