From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Tejas Upadhyay <tejas.upadhyay@intel.com>
Cc: intel-xe@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
badal.nilawar@intel.com, vinay.belgaumkar@intel.com
Subject: Re: [RFC PATCH 2/2] drm/uapi: Adjust uniform spacing
Date: Wed, 08 Jan 2025 09:11:26 -0800 [thread overview]
Message-ID: <857c75b58h.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20250108150603.2995709-3-tejas.upadhyay@intel.com>
On Wed, 08 Jan 2025 07:06:03 -0800, Tejas Upadhyay wrote:
>
> Extensions in exec queue creation formatted to have uniform
> spacing in defines.
>
> Signed-off-by: Tejas Upadhyay <tejas.upadhyay@intel.com>
> ---
> include/uapi/drm/xe_drm.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/include/uapi/drm/xe_drm.h b/include/uapi/drm/xe_drm.h
> index 62447f5422d8..868dac05c100 100644
> --- a/include/uapi/drm/xe_drm.h
> +++ b/include/uapi/drm/xe_drm.h
> @@ -1108,9 +1108,9 @@ struct drm_xe_vm_bind {
> *
> */
> struct drm_xe_exec_queue_create {
> -#define DRM_XE_EXEC_QUEUE_EXTENSION_SET_PROPERTY 0
> -#define DRM_XE_EXEC_QUEUE_SET_PROPERTY_PRIORITY 0
> -#define DRM_XE_EXEC_QUEUE_SET_PROPERTY_TIMESLICE 1
> +#define DRM_XE_EXEC_QUEUE_EXTENSION_SET_PROPERTY 0
> +#define DRM_XE_EXEC_QUEUE_SET_PROPERTY_PRIORITY 0
> +#define DRM_XE_EXEC_QUEUE_SET_PROPERTY_TIMESLICE 1
This is wrong. For the lower 2 #define's are sub-property types of
set_property. The original code is correct.
next prev parent reply other threads:[~2025-01-08 17:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-08 15:06 [RFC PATCH 0/2] Add UAPI support for low latency hint Tejas Upadhyay
2025-01-08 15:06 ` [RFC PATCH 1/2] drm/xe/guc: Use exec queue hints for GT frequency Tejas Upadhyay
2025-01-08 19:57 ` Lucas De Marchi
2025-01-08 15:06 ` [RFC PATCH 2/2] drm/uapi: Adjust uniform spacing Tejas Upadhyay
2025-01-08 17:11 ` Dixit, Ashutosh [this message]
2025-01-08 18:26 ` ✓ CI.Patch_applied: success for Add UAPI support for low latency hint Patchwork
2025-01-08 18:26 ` ✓ CI.checkpatch: " Patchwork
2025-01-08 18:27 ` ✓ CI.KUnit: " Patchwork
2025-01-08 18:45 ` ✓ CI.Build: " Patchwork
2025-01-08 18:48 ` ✓ CI.Hooks: " Patchwork
2025-01-08 18:49 ` ✓ CI.checksparse: " Patchwork
2025-01-08 19:33 ` ✓ Xe.CI.BAT: " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=857c75b58h.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=badal.nilawar@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=tejas.upadhyay@intel.com \
--cc=vinay.belgaumkar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox