Re: [PATCH 2/2] drm/xe: Use XE_BO_FLAG_NEEDS_WC_CPU for DSB

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Fri, 20 Sep 2024 12:01:07 -0700, Maarten Lankhorst wrote:
>
> Now that we have an explicit flag, we can stop abusing the scanout flag
> for this.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> ---
>  drivers/gpu/drm/xe/display/xe_dsb_buffer.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/display/xe_dsb_buffer.c b/drivers/gpu/drm/xe/display/xe_dsb_buffer.c
> index 9f941fc2e36b..59c5aedefc25 100644
> --- a/drivers/gpu/drm/xe/display/xe_dsb_buffer.c
> +++ b/drivers/gpu/drm/xe/display/xe_dsb_buffer.c
> @@ -47,7 +47,7 @@ bool intel_dsb_buffer_create(struct intel_crtc *crtc, struct intel_dsb_buffer *d
>				   NULL, PAGE_ALIGN(size),
>				   ttm_bo_type_kernel,
>				   XE_BO_FLAG_VRAM_IF_DGFX(xe_device_get_root_tile(xe)) |
> -				   XE_BO_FLAG_SCANOUT | XE_BO_FLAG_GGTT);
> +				   XE_BO_FLAG_NEEDS_WC_CPU | XE_BO_FLAG_GGTT);

Also delete the comment just above the function call above: "Set scanout
flag for WC mapping".

>	if (IS_ERR(obj)) {
>		kfree(vma);
>		return false;
> --
> 2.45.2
>