From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Kees Cook <kees@kernel.org>
Cc: Harish Chegondi <harish.chegondi@intel.com>,
intel-xe@lists.freedesktop.org
Subject: Re: [PATCH 1/1] drm/xe/eustall: Use copy_from_user() instead of __copy_from_user()
Date: Wed, 30 Apr 2025 15:49:41 -0700 [thread overview]
Message-ID: <85r019qn7e.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <202504301151.81F35C4@keescook>
On Wed, 30 Apr 2025 11:51:18 -0700, Kees Cook wrote:
>
> On Tue, Apr 29, 2025 at 10:11:11PM -0700, Harish Chegondi wrote:
> > copy_from_user() has more checks and is more safer than
> > __copy_from_user()
> >
> > Fixes: 1537ec85ebd7 ("drm/xe/uapi: Introduce API for EU stall sampling")
> > Signed-off-by: Harish Chegondi <harish.chegondi@intel.com>
>
> Thanks!
>
> Reviewed-by: Kees Cook <kees@kernel.org>
Harish, could we add the other instances of __copy_from_user() also to this
patch? So we can fix all of them in one go.
Thanks.
--
Ashutosh
next prev parent reply other threads:[~2025-04-30 22:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-30 5:11 [PATCH 1/1] drm/xe/eustall: Use copy_from_user() instead of __copy_from_user() Harish Chegondi
2025-04-30 7:00 ` ✓ CI.Patch_applied: success for series starting with [1/1] " Patchwork
2025-04-30 7:01 ` ✓ CI.checkpatch: " Patchwork
2025-04-30 7:02 ` ✓ CI.KUnit: " Patchwork
2025-04-30 7:10 ` ✓ CI.Build: " Patchwork
2025-04-30 7:12 ` ✓ CI.Hooks: " Patchwork
2025-04-30 7:14 ` ✓ CI.checksparse: " Patchwork
2025-04-30 12:09 ` ✗ Xe.CI.Full: failure " Patchwork
2025-04-30 18:51 ` [PATCH 1/1] " Kees Cook
2025-04-30 22:49 ` Dixit, Ashutosh [this message]
2025-05-06 7:55 ` ✗ Xe.CI.BAT: failure for series starting with [1/1] " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85r019qn7e.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=harish.chegondi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=kees@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox