Re: [PATCH v2] drm/xe/guc: Fix missing init value and add register order check

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Tue, 05 Nov 2024 12:54:49 -0800, Dong, Zhanjun wrote:
> >> +

Hi Zhanjun,

> >> + case REG_64BIT_HI_DW: {
> > alan: nit: now that you have moved to a switch statement, is this { really required?
> Few concerns:
> 1. Have {} here will make it works on most compilers and ANSIC settings.
> 2. Local variable "u64 value_qw" will be limited within this case
> statement, I don't want it to be referenced on other case statement.

Do you have a compiler where it doesn't compile? Looks like you can declare
the variable following case without the brace, compiles at least with gcc.

Also, if you need the brace, the 'break' at the end should be inside the
brace. This is used in a few places in xe, you can see how it's done :)

Thanks.
--
Ashutosh