From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Badal Nilawar <badal.nilawar@intel.com>
Cc: intel-gfx@lists.freedesktop.org, lucas.demarchi@intel.com,
thomas.hellstrom@intel.com, rodrigo.vivi@intel.com,
intel-xe@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/hwmon: Fix abi doc warnings
Date: Sat, 27 Jan 2024 12:10:08 -0800 [thread overview]
Message-ID: <85ttmyczbz.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20240127165040.2348009-1-badal.nilawar@intel.com>
On Sat, 27 Jan 2024 08:50:40 -0800, Badal Nilawar wrote:
>
Hi Badal,
> This fixes warnings in xe, i915 hwmon docs
>
> Warning: /sys/devices/.../hwmon/hwmon<i>/curr1_crit is defined 2 times: Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:35 Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:52
> Warning: /sys/devices/.../hwmon/hwmon<i>/energy1_input is defined 2 times: Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:54 Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:65
> Warning: /sys/devices/.../hwmon/hwmon<i>/in0_input is defined 2 times: Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:46 Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:0
> Warning: /sys/devices/.../hwmon/hwmon<i>/power1_crit is defined 2 times: Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:22 Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:39
> Warning: /sys/devices/.../hwmon/hwmon<i>/power1_max is defined 2 times: Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:0 Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:8
> Warning: /sys/devices/.../hwmon/hwmon<i>/power1_max_interval is defined 2 times: Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:62 Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:30
> Warning: /sys/devices/.../hwmon/hwmon<i>/power1_rated_max is defined 2 times: Documentation/ABI/testing/sysfs-driver-intel-xe-hwmon:14 Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon:22
/snip/
> diff --git a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon
> index 8d7d8f05f6cd..92fe7c5c5ac1 100644
> --- a/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon
> +++ b/Documentation/ABI/testing/sysfs-driver-intel-i915-hwmon
> @@ -1,4 +1,4 @@
> -What: /sys/devices/.../hwmon/hwmon<i>/in0_input
Are the warnings happening because this path doesn't exist?
> +What: /sys/bus/pci/drivers/i915/.../hwmon/hwmon<i>/in0_input
So this I guess could also be
/sys/class/drm/card<n>/device/hwmon/hwmon<i>/in0_input?
But no need to change, what you have is also a valid path. But maybe to
make clear:
/sys/bus/pci/drivers/i915/<device>/hwmon/hwmon<i>/in0_input
?
But anyway...
Assuming you turned on the htmldoc build option, could reproduce this and
verified that this patch is fixing these warnings, this is:
Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
next prev parent reply other threads:[~2024-01-27 20:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-27 16:50 [PATCH v2] drm/hwmon: Fix abi doc warnings Badal Nilawar
2024-01-27 16:42 ` ✓ CI.Patch_applied: success for " Patchwork
2024-01-27 16:42 ` ✗ CI.checkpatch: warning " Patchwork
2024-01-27 16:42 ` ✗ CI.KUnit: failure " Patchwork
2024-01-27 20:10 ` Dixit, Ashutosh [this message]
2024-01-29 15:18 ` Re: [PATCH v2] " Lucas De Marchi
2024-01-29 15:22 ` Rodrigo Vivi
2024-01-29 16:36 ` Jani Nikula
2024-01-30 4:43 ` Lucas De Marchi
2024-01-29 16:24 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=85ttmyczbz.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=badal.nilawar@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=thomas.hellstrom@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox