Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v5] drm/i915: limit eDP MSO pipe only for display version 20 and below
@ 2024-04-04  9:16 Luca Coelho
  2024-04-04 14:47 ` ✓ CI.Patch_applied: success for drm/i915: limit eDP MSO pipe only for display version 20 and below (rev2) Patchwork
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: Luca Coelho @ 2024-04-04  9:16 UTC (permalink / raw)
  To: intel-gfx
  Cc: intel-xe, ville.syrjala, jani.nikula, gustavo.sousa, james.ausmus

The pipes that can be used for eDP MSO are limited to pipe A (and
sometimes also pipe B) only for display version 20 and below.

Modify the function that returns the pipe mask for eDP MSO so that
these limitations only apply to version 20 and below, enabling all
pipes otherwise.

Bspec: 68923
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: James Ausmus <james.ausmus@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---

In v5:
   * fixed Ville's name's wrong charset, which prevented patchwork
     from picking this up.

In v4:
   * actually go back to unrestricting only for > 20.  I sent the
     wrong patch version in v3.

In v3:
   * go back to unrestricing only for > 20, since the change for
     versions 14 to 20 should be tested separately;
   * simplify the if blocks [Ville].

In v2:
   * allow pipes A and B from ver 14 to 20 [Gustavo]

 drivers/gpu/drm/i915/display/intel_ddi.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index a3d3d4942eb1..5d2863c43296 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -2336,10 +2336,15 @@ static void intel_ddi_power_up_lanes(struct intel_encoder *encoder,
 	}
 }
 
-/* Splitter enable for eDP MSO is limited to certain pipes. */
+/*
+ * Splitter enable for eDP MSO is limited to certain pipes, on certain
+ * platforms.
+ */
 static u8 intel_ddi_splitter_pipe_mask(struct drm_i915_private *i915)
 {
-	if (IS_ALDERLAKE_P(i915))
+	if (DISPLAY_VER(i915) > 20)
+		return ~0;
+	else if (IS_ALDERLAKE_P(i915))
 		return BIT(PIPE_A) | BIT(PIPE_B);
 	else
 		return BIT(PIPE_A);
-- 
2.39.2


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-04-18 11:28 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-04-04  9:16 [PATCH v5] drm/i915: limit eDP MSO pipe only for display version 20 and below Luca Coelho
2024-04-04 14:47 ` ✓ CI.Patch_applied: success for drm/i915: limit eDP MSO pipe only for display version 20 and below (rev2) Patchwork
2024-04-04 14:48 ` ✓ CI.checkpatch: " Patchwork
2024-04-04 14:49 ` ✓ CI.KUnit: " Patchwork
2024-04-04 15:00 ` ✓ CI.Build: " Patchwork
2024-04-04 15:03 ` ✓ CI.Hooks: " Patchwork
2024-04-04 15:04 ` ✗ CI.checksparse: warning " Patchwork
2024-04-04 15:24 ` ✓ CI.BAT: success " Patchwork
2024-04-18 11:28 ` [PATCH v5] drm/i915: limit eDP MSO pipe only for display version 20 and below Jani Nikula

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox