From: Jani Nikula <jani.nikula@intel.com>
To: Arun R Murthy <arun.r.murthy@intel.com>,
intel-xe@lists.freedesktop.org, uma.shankar@intel.com
Cc: Arun R Murthy <arun.r.murthy@intel.com>
Subject: Re: [Intel-xe] [PATCHv2 1/2] drm/i915: Remove the module parameter 'fastboot'
Date: Tue, 26 Sep 2023 10:40:54 +0300 [thread overview]
Message-ID: <874jjhmlfd.fsf@intel.com> (raw)
In-Reply-To: <20230926051124.583554-1-arun.r.murthy@intel.com>
On Tue, 26 Sep 2023, Arun R Murthy <arun.r.murthy@intel.com> wrote:
> By default fastboot is enabled on all Display 9+ platforms and disabled
> on older platforms. Its not necessary to retain this as a module
> parameter.
>
> v2: remove this parameter for i915 as well (Jani N, Ville)
Please send this to intel-gfx first, get it merged, then backport to xe
with git cherry-pick -x.
Before the backport, remove the relevant ifdefs. The order presented
here will not rebase nicely.
BR,
Jani.
>
> Signed-off-by: Arun R Murthy <arun.r.murthy@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 3 ---
> drivers/gpu/drm/i915/i915_params.c | 5 -----
> drivers/gpu/drm/i915/i915_params.h | 1 -
> 3 files changed, 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index b2e16cb8d026..0bfd4ea12065 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -4987,9 +4987,6 @@ pipe_config_mismatch(bool fastset, const struct intel_crtc *crtc,
> static bool fastboot_enabled(struct drm_i915_private *dev_priv)
> {
> #ifdef I915
> - if (dev_priv->params.fastboot != -1)
> - return dev_priv->params.fastboot;
> -
> /* Enable fastboot by default on Skylake and newer */
> if (DISPLAY_VER(dev_priv) >= 9)
> return true;
> diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
> index 0a171b57fd8f..036c4c3ed6ed 100644
> --- a/drivers/gpu/drm/i915/i915_params.c
> +++ b/drivers/gpu/drm/i915/i915_params.c
> @@ -137,11 +137,6 @@ i915_param_named_unsafe(enable_ips, int, 0400, "Enable IPS (default: true)");
> i915_param_named_unsafe(enable_dpt, bool, 0400,
> "Enable display page table (DPT) (default: true)");
>
> -i915_param_named(fastboot, int, 0400,
> - "Try to skip unnecessary mode sets at boot time "
> - "(0=disabled, 1=enabled) "
> - "Default: -1 (use per-chip default)");
> -
> i915_param_named_unsafe(load_detect_test, bool, 0400,
> "Force-enable the VGA load detect code for testing (default:false). "
> "For developers only.");
> diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
> index 68abf0ad6c00..d5194b039aab 100644
> --- a/drivers/gpu/drm/i915/i915_params.h
> +++ b/drivers/gpu/drm/i915/i915_params.h
> @@ -72,7 +72,6 @@ struct drm_printer;
> param(int, edp_vswing, 0, 0400) \
> param(unsigned int, reset, 3, 0600) \
> param(unsigned int, inject_probe_failure, 0, 0) \
> - param(int, fastboot, -1, 0600) \
> param(int, enable_dpcd_backlight, -1, 0600) \
> param(char *, force_probe, CONFIG_DRM_I915_FORCE_PROBE, 0400) \
> param(unsigned int, request_timeout_ms, CONFIG_DRM_I915_REQUEST_TIMEOUT, CONFIG_DRM_I915_REQUEST_TIMEOUT ? 0600 : 0) \
--
Jani Nikula, Intel
next prev parent reply other threads:[~2023-09-26 7:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-24 14:47 [Intel-xe] [PATCH 1/2] drm/xe: Add module parameter 'fastboot' Arun R Murthy
2023-09-24 14:47 ` [Intel-xe] [PATCH 2/2] Revert "FIXME: drm/i915: xe doesn't have fastboot module parameter" Arun R Murthy
2023-09-25 9:17 ` Shankar, Uma
2023-09-25 11:27 ` Jani Nikula
2023-09-24 14:59 ` [Intel-xe] ✓ CI.Patch_applied: success for series starting with [1/2] drm/xe: Add module parameter 'fastboot' Patchwork
2023-09-24 14:59 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-09-24 15:00 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-09-24 15:07 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-24 15:08 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-09-24 15:09 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-09-24 15:43 ` [Intel-xe] ✓ CI.BAT: success " Patchwork
2023-09-25 9:15 ` [Intel-xe] [PATCH 1/2] " Shankar, Uma
2023-09-25 11:29 ` Jani Nikula
2023-09-25 11:47 ` Ville Syrjälä
2023-09-26 4:28 ` Murthy, Arun R
2023-09-26 5:11 ` [Intel-xe] [PATCHv2 1/2] drm/i915: Remove the " Arun R Murthy
2023-09-26 5:11 ` [Intel-xe] [PATCHv2 2/2] Revert "FIXME: drm/i915: xe doesn't have fastboot module parameter" Arun R Murthy
2023-09-26 7:40 ` Jani Nikula [this message]
2023-09-26 5:54 ` [Intel-xe] ✗ CI.Patch_applied: failure for series starting with [PATCHv2,1/2] drm/i915: Remove the module parameter 'fastboot' (rev2) Patchwork
2023-10-12 8:47 ` [Intel-xe] [PATCH 1/2] drm/i915: Remove the module parameter 'fastboot' Arun R Murthy
2023-10-12 8:47 ` [Intel-xe] [PATCH 2/2] Revert "FIXME: drm/i915: xe doesn't have fastboot module parameter" Arun R Murthy
2023-10-12 9:06 ` [Intel-xe] [PATCH 1/2] drm/i915: Remove the module parameter 'fastboot' Jani Nikula
2023-10-12 9:10 ` Murthy, Arun R
2023-10-12 9:23 ` Jani Nikula
2023-10-12 9:14 ` [Intel-xe] ✗ CI.Patch_applied: failure for series starting with [2/2] Revert "FIXME: drm/i915: xe doesn't have fastboot module parameter" (rev4) Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874jjhmlfd.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=arun.r.murthy@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=uma.shankar@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox