Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 00/10] drm/xe: Clean up adjust_idledly() and implement Wa_16031259911
@ 2026-10-30 22:57 Gustavo Sousa
  2026-10-30 22:57 ` [PATCH v2 01/10] drm/xe: Bail from adjust_idledly() if in VF mode Gustavo Sousa
                   ` (13 more replies)
  0 siblings, 14 replies; 23+ messages in thread
From: Gustavo Sousa @ 2026-10-30 22:57 UTC (permalink / raw)
  To: intel-xe
  Cc: Gustavo Sousa, Matt Atwood, Dnyaneshwar Bhadane, Matt Roper,
	Shekhar Chauhan

There is a new workaround, namely Wa_16031259911, to be added to the
xe driver that applies to graphics IP versions 35.10 and 35.11.  The
workaround is similar to existing ones that apply adjustments to
RING_IDLEDLY.

The current implementation can be improved though: adjust_idledly()
can be cleaned up and refactored to make the code easier to follow
sequentially as well as to add new workarounds (such as
Wa_16031259911); the GuC ADS regset accounting has a subtle issue
where the addition of RING_IDLEDLY is not accounted for.

This series addresses those issues first and then adds the
implementation of Wa_16031259911 as the final step.

Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
---
Changes in v2:
- Change idledly_units_ps and maxcnt_units_ps to u64 in adjust_idledly()
  to avoid 32-bit multiplication overflow. (Sashiko, Matt)
- Replace the call-site comment for adjust_idledly() with a comment at
  the function definition instead of just dropping it. (Matt)
- Link to v1: https://patch.msgid.link/20261023-wa_16031259911-v1-0-b0453f79c4e1@intel.com

---
Gustavo Sousa (10):
      drm/xe: Bail from adjust_idledly() if in VF mode
      drm/xe: Sync Wa_16023105232 in xe_was to match OOB rule
      drm/xe: Use picosecond as common unit in adjust_idledly()
      drm/xe: Factor out {min,max}_idledly_ps in adjust_idledly()
      drm/xe: Bail from adjust_idledly() if no applicable workaround
      drm/xe: Drop early and redundant workaround checks in adjust_idledly()
      drm/xe: Replace MAXCNT comment with a comment on adjust_idledly()
      drm/xe/guc: Increment regset size for Wa_1607983814 inside hwe loop
      drm/xe/guc: Increment regset size for RING_IDLEDLY workarounds
      drm/xe: Implement Wa_16031259911

 drivers/gpu/drm/xe/xe_guc_ads.c    |  16 ++--
 drivers/gpu/drm/xe/xe_hw_engine.c  | 158 ++++++++++++++++++-------------------
 drivers/gpu/drm/xe/xe_wa.c         |   5 +-
 drivers/gpu/drm/xe/xe_wa_oob.rules |   6 +-
 4 files changed, 93 insertions(+), 92 deletions(-)
---
base-commit: 238c1e3e984e2b7f948cb24165314b8d719a23d6
change-id: 20261021-wa_16031259911-3a83c69d8570

Best regards,
--  
Gustavo Sousa <gustavo.sousa@intel.com>


^ permalink raw reply	[flat|nested] 23+ messages in thread

end of thread, other threads:[~2026-11-04 17:06 UTC | newest]

Thread overview: 23+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-10-30 22:57 [PATCH v2 00/10] drm/xe: Clean up adjust_idledly() and implement Wa_16031259911 Gustavo Sousa
2026-10-30 22:57 ` [PATCH v2 01/10] drm/xe: Bail from adjust_idledly() if in VF mode Gustavo Sousa
2026-10-30 22:57 ` [PATCH v2 02/10] drm/xe: Sync Wa_16023105232 in xe_was to match OOB rule Gustavo Sousa
2026-10-30 22:57 ` [PATCH v2 03/10] drm/xe: Use picosecond as common unit in adjust_idledly() Gustavo Sousa
2026-11-02 18:54   ` Matt Atwood
2026-10-30 22:57 ` [PATCH v2 04/10] drm/xe: Factor out {min,max}_idledly_ps " Gustavo Sousa
2026-11-02 12:42   ` Vivekanandan, Balasubramani
2026-11-03 14:07     ` Gustavo Sousa
2026-10-30 22:57 ` [PATCH v2 05/10] drm/xe: Bail from adjust_idledly() if no applicable workaround Gustavo Sousa
2026-11-02 12:54   ` Vivekanandan, Balasubramani
2026-11-03 14:20     ` Gustavo Sousa
2026-11-04 17:06       ` Matt Atwood
2026-10-30 22:57 ` [PATCH v2 06/10] drm/xe: Drop early and redundant workaround checks in adjust_idledly() Gustavo Sousa
2026-11-02 12:58   ` Vivekanandan, Balasubramani
2026-10-30 22:57 ` [PATCH v2 07/10] drm/xe: Replace MAXCNT comment with a comment on adjust_idledly() Gustavo Sousa
2026-11-02 18:48   ` Matt Atwood
2026-10-30 22:57 ` [PATCH v2 08/10] drm/xe/guc: Increment regset size for Wa_1607983814 inside hwe loop Gustavo Sousa
2026-10-30 22:57 ` [PATCH v2 09/10] drm/xe/guc: Increment regset size for RING_IDLEDLY workarounds Gustavo Sousa
2026-10-30 22:57 ` [PATCH v2 10/10] drm/xe: Implement Wa_16031259911 Gustavo Sousa
2026-10-30 23:15 ` ✗ CI.checkpatch: warning for drm/xe: Clean up adjust_idledly() and implement Wa_16031259911 (rev2) Patchwork
2026-10-30 23:17 ` ✓ CI.KUnit: success " Patchwork
2026-10-30 23:53 ` ✓ Xe.CI.BAT: " Patchwork
2026-10-31 19:00 ` ✓ Xe.CI.FULL: " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox