public inbox for intel-xe@lists.freedesktop.org
 help / color / mirror / Atom feed
From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Shuicheng Lin <shuicheng.lin@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [PATCH] drm/xe/configfs: Fix is_bound() pci_dev lifetime
Date: Wed, 21 Jan 2026 10:31:12 -0800	[thread overview]
Message-ID: <878qdqu8b3.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20260121173750.3090907-2-shuicheng.lin@intel.com>

On Wed, 21 Jan 2026 09:37:51 -0800, Shuicheng Lin wrote:
>
> Move pci_dev_put() after pci_dbg() to avoid using pdev after dropping its
> reference.
>
> Fixes: 2674f1ef29f46 ("drm/xe/configfs: Block runtime attribute changes")
> Signed-off-by: Shuicheng Lin <shuicheng.lin@intel.com>

Reviewed-by: Ashutosh Dixit <ashutosh.dixit@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_configfs.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_configfs.c b/drivers/gpu/drm/xe/xe_configfs.c
> index 9f6251b1008b..82edd0466005 100644
> --- a/drivers/gpu/drm/xe/xe_configfs.c
> +++ b/drivers/gpu/drm/xe/xe_configfs.c
> @@ -347,11 +347,10 @@ static bool is_bound(struct xe_config_group_device *dev)
>		return false;
>
>	ret = pci_get_drvdata(pdev);
> -	pci_dev_put(pdev);
> -
>	if (ret)
>		pci_dbg(pdev, "Already bound to driver\n");
>
> +	pci_dev_put(pdev);
>	return ret;
>  }
>
> --
> 2.50.1
>

  parent reply	other threads:[~2026-01-21 18:31 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-21 17:37 [PATCH] drm/xe/configfs: Fix is_bound() pci_dev lifetime Shuicheng Lin
2026-01-21 18:05 ` ✓ CI.KUnit: success for " Patchwork
2026-01-21 18:31 ` Dixit, Ashutosh [this message]
2026-01-21 18:40 ` ✓ Xe.CI.BAT: " Patchwork
2026-01-22  3:49 ` ✗ Xe.CI.Full: failure " Patchwork
2026-01-22 16:41   ` Lin, Shuicheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=878qdqu8b3.wl-ashutosh.dixit@intel.com \
    --to=ashutosh.dixit@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=shuicheng.lin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox