Re: [PATCH] drm/xe/bmg: Add PCI IDs

[Jani Nikula <jani.nikula@linux.intel.com>]

On Tue, 04 Jun 2024, Lucas De Marchi <lucas.demarchi@intel.com> wrote:
> On Tue, Jun 04, 2024 at 11:03:51AM GMT, Jani Nikula wrote:
>>On Mon, 03 Jun 2024, Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com> wrote:
>>> From: Matt Roper <matthew.d.roper@intel.com>
>>>
>>> Add the initial set of device IDs for Battlemage.
>>>
>>> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
>>> Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
>>
>>Please note that since commit 54836ee194f9 ("drm/i915/display: change
>>display probe to identify GMD ID based platforms") you'll also need to
>>add the PCI IDs to i915_pciids.h and add the platform desc in
>>i915/display/intel_display_device.c for display probe.
>
> that was not the plan when we started xe_pciids.h. Now that display side
> will use pci id to find a static desc, I think there's no point in
> keeping the headers separate. Should we unify them?

Plans changed... and I agree we should unify. Though I don't think
there's any rush. The hard part was done when I switched i915 to the
same type of macros as xe uses. But do we want to have a single
include/drm/intel/pciids.h or split by some criteria?

BR,
Jani.


-- 
Jani Nikula, Intel