Re: [PATCH] drm/xe/bmg: Add PCI IDs

[Jani Nikula <jani.nikula@linux.intel.com>]

On Mon, 03 Jun 2024, Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com> wrote:
> From: Matt Roper <matthew.d.roper@intel.com>
>
> Add the initial set of device IDs for Battlemage.
>
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> Signed-off-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>

Please note that since commit 54836ee194f9 ("drm/i915/display: change
display probe to identify GMD ID based platforms") you'll also need to
add the PCI IDs to i915_pciids.h and add the platform desc in
i915/display/intel_display_device.c for display probe.

BR,
Jani.

> ---
>  drivers/gpu/drm/xe/xe_pci.c   | 3 ++-
>  include/drm/intel/xe_pciids.h | 7 +++++++
>  2 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_pci.c b/drivers/gpu/drm/xe/xe_pci.c
> index 5655222aa4e1..ebff5ea79b1d 100644
> --- a/drivers/gpu/drm/xe/xe_pci.c
> +++ b/drivers/gpu/drm/xe/xe_pci.c
> @@ -340,7 +340,7 @@ static const struct xe_device_desc lnl_desc = {
>  	.require_force_probe = true,
>  };
>  
> -static const struct xe_device_desc bmg_desc __maybe_unused = {
> +static const struct xe_device_desc bmg_desc = {
>  	DGFX_FEATURES,
>  	PLATFORM(BATTLEMAGE),
>  	.has_display = true,
> @@ -391,6 +391,7 @@ static const struct pci_device_id pciidlist[] = {
>  	XE_PVC_IDS(INTEL_VGA_DEVICE, &pvc_desc),
>  	XE_MTL_IDS(INTEL_VGA_DEVICE, &mtl_desc),
>  	XE_LNL_IDS(INTEL_VGA_DEVICE, &lnl_desc),
> +	XE_BMG_IDS(INTEL_VGA_DEVICE, &bmg_desc),
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(pci, pciidlist);
> diff --git a/include/drm/intel/xe_pciids.h b/include/drm/intel/xe_pciids.h
> index c7fc288dacee..73d972a8aca1 100644
> --- a/include/drm/intel/xe_pciids.h
> +++ b/include/drm/intel/xe_pciids.h
> @@ -208,4 +208,11 @@
>  	MACRO__(0x64A0, ## __VA_ARGS__), \
>  	MACRO__(0x64B0, ## __VA_ARGS__)
>  
> +#define XE_BMG_IDS(MACRO__, ...) \
> +	MACRO__(0xE202, ## __VA_ARGS__), \
> +	MACRO__(0xE20B, ## __VA_ARGS__), \
> +	MACRO__(0xE20C, ## __VA_ARGS__), \
> +	MACRO__(0xE20D, ## __VA_ARGS__), \
> +	MACRO__(0xE212, ## __VA_ARGS__)
> +
>  #endif

-- 
Jani Nikula, Intel