From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"maarten.lankhorst@linux.intel.com"
<maarten.lankhorst@linux.intel.com>
Cc: "Nikula, Jani" <jani.nikula@intel.com>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>
Subject: Re: [PATCH v5 0/9] Intel_fb.c refactoring
Date: Fri, 8 Dec 2023 06:18:38 +0000 [thread overview]
Message-ID: <87cc527a8e5021456fb37781ac97bda8f5794bed.camel@intel.com> (raw)
In-Reply-To: <da07bf9b-116b-48c6-bd4c-20ffcb20da54@linux.intel.com>
On Thu, 2023-12-07 at 16:10 +0100, Maarten Lankhorst wrote:
> Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>
> I've noticed v2 has a a-b from Jani, seems to be missing in later
> versions?
>
Thank you Maarten. These are now pushed to drm-xe-next with your rb tag
and ack from Jani.
BR,
Jouni Högander
> Den 2023-12-07 kl. 06:22, skrev Jouni Högander:
> > This patch set is refactoring intel_fb.c code to get rid of
> > ifdefs. This is done by splitting i915 and Xe specific parts from
> > intel_fb.c into their own source files.
> >
> > Some ifdefs are tackled by adding definitions into Xe compatibility
> > headers.
> >
> > Patch 7. should be sent to intel-gfx@lists.freedesktop.org.
> >
> > v5:
> > - s/user_mode_cmd/mode_cmd
> > - Fix typo intel_fb vs. intel_fb_bo
> > v4: Empty function instead of define
> > v3:
> > - intel_fb_bo_framebuffer_fini added
> > - xe_bo_get/put and unpin moved to
> > intel_fb_bo_framebuffer_init/fini
> > v2: i915 changes are now backported
> >
> > Cc: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > Cc: Jani Nikula <jani.nikula@intel.com>
> >
> > Jouni Högander (9):
> > Revert "FIXME: drm/i915: xe intel_fb.c framebuffer init and
> > destroy xe
> > changes"
> > fixup! FIXME: drm/i915/display: Remaining changes to make xe
> > compile
> > drm/i915/display: use intel_bo_to_drm_bo in intel_fb.c
> > drm/i915/display: Convert intel_fb_modifier_to_tiling as non-
> > static
> > drm/i915/display: Handle invalid fb_modifier in
> > intel_fb_modifier_to_tiling
> > drm/i915/display: Split i915 specific code away from intel_fb.c
> > drm/i915/display: Add intel_fb_bo_framebuffer_fini
> > fixup! drm/xe/display: Implement display support
> > fixup! drm/xe/display: Implement display support
> >
> > drivers/gpu/drm/i915/Makefile | 1 +
> > drivers/gpu/drm/i915/display/intel_fb.c | 247 +++++--------
> > -----
> > drivers/gpu/drm/i915/display/intel_fb.h | 2 +
> > drivers/gpu/drm/i915/display/intel_fb_bo.c | 97 +++++++
> > drivers/gpu/drm/i915/display/intel_fb_bo.h | 26 ++
> > drivers/gpu/drm/xe/Makefile | 1 +
> > .../compat-i915-headers/gem/i915_gem_object.h | 16 ++
> > drivers/gpu/drm/xe/display/intel_fb_bo.c | 74 ++++++
> > drivers/gpu/drm/xe/display/intel_fb_bo.h | 24 ++
> > 9 files changed, 305 insertions(+), 183 deletions(-)
> > create mode 100644 drivers/gpu/drm/i915/display/intel_fb_bo.c
> > create mode 100644 drivers/gpu/drm/i915/display/intel_fb_bo.h
> > create mode 100644 drivers/gpu/drm/xe/display/intel_fb_bo.c
> > create mode 100644 drivers/gpu/drm/xe/display/intel_fb_bo.h
> >
prev parent reply other threads:[~2023-12-08 6:18 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-07 5:22 [Intel-xe] [PATCH v5 0/9] Intel_fb.c refactoring Jouni Högander
2023-12-07 5:22 ` [Intel-xe] [PATCH v5 1/9] Revert "FIXME: drm/i915: xe intel_fb.c framebuffer init and destroy xe changes" Jouni Högander
2023-12-07 5:22 ` [Intel-xe] [PATCH v5 2/9] fixup! FIXME: drm/i915/display: Remaining changes to make xe compile Jouni Högander
2023-12-07 5:22 ` [Intel-xe] [PATCH v5 3/9] drm/i915/display: use intel_bo_to_drm_bo in intel_fb.c Jouni Högander
2023-12-07 5:22 ` [Intel-xe] [PATCH v5 4/9] drm/i915/display: Convert intel_fb_modifier_to_tiling as non-static Jouni Högander
2023-12-07 5:22 ` [Intel-xe] [PATCH v5 5/9] drm/i915/display: Handle invalid fb_modifier in intel_fb_modifier_to_tiling Jouni Högander
2023-12-07 5:22 ` [Intel-xe] [PATCH v5 6/9] drm/i915/display: Split i915 specific code away from intel_fb.c Jouni Högander
2023-12-07 5:22 ` [Intel-xe] [PATCH v5 7/9] drm/i915/display: Add intel_fb_bo_framebuffer_fini Jouni Högander
2023-12-07 5:22 ` [Intel-xe] [PATCH v5 8/9] fixup! drm/xe/display: Implement display support Jouni Högander
2023-12-07 5:22 ` [Intel-xe] [PATCH v5 9/9] " Jouni Högander
2023-12-07 5:25 ` [Intel-xe] ✓ CI.Patch_applied: success for Intel_fb.c refactoring (rev7) Patchwork
2023-12-07 5:26 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-12-07 5:27 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-12-07 5:34 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-12-07 5:35 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-12-07 5:36 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-12-07 6:11 ` [Intel-xe] ✓ CI.BAT: success " Patchwork
2023-12-07 15:10 ` [PATCH v5 0/9] Intel_fb.c refactoring Maarten Lankhorst
2023-12-08 6:18 ` Hogander, Jouni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87cc527a8e5021456fb37781ac97bda8f5794bed.camel@intel.com \
--to=jouni.hogander@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox