From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Matthew Auld <matthew.auld@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH v12 00/13] xe_device_mem_access fixes and related bits
Date: Thu, 29 Jun 2023 23:21:46 -0700 [thread overview]
Message-ID: <87edlt5v2d.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <20230626105037.43780-15-matthew.auld@intel.com>
On Mon, 26 Jun 2023 03:50:38 -0700, Matthew Auld wrote:
>
> Main goal is to fix the races in xe_device_mem_access_get(). With that fixed we
> can clean up some hacks and also start rolling it out to more places that need
> it, including now asserting it around every mmio access. We also add lockdep
> annotations for xe_device_mem_access_get() and fix the remaining lockdep
> fallout.
>
> v11 -> v12:
> - freq_rpe_show also needs the device to be awake
> - Improvements to the lockdep annotation patch
Just FYI, fwiw this is from my local branch, but even with this series I am
seeing this on DG2. Probe is fine but as soon as my IGT (perf) runs the
trace below spews out. The unit test runs fine on RPLP. If there's a
temporary workaround for this I'd like to know. Thanks.
-Ashutosh
[ 486.110571] xe: loading out-of-tree module taints kernel.
[ 486.131776] xe 0000:03:00.0: vgaarb: deactivate vga console
[ 486.133136] GT topology dss mask (geometry): 00000000,0000ff00
[ 486.133139] GT topology dss mask (compute): 00000000,0000ff00
[ 486.133141] GT topology EU mask per DSS: 0000ffff
[ 486.133636] xe 0000:03:00.0: [drm] VISIBLE VRAM: 0x0000004000000000, 0x0000000200000000
[ 486.133686] xe 0000:03:00.0: [drm] VRAM[0, 0]: 0x0000004000000000, 0x000000017c800000
[ 486.133688] xe 0000:03:00.0: [drm] Total VRAM: 0x0000004000000000, 0x0000000180000000
[ 486.133690] xe 0000:03:00.0: [drm] Available VRAM: 0x0000004000000000, 0x000000017c800000
[ 486.195204] xe 0000:03:00.0: [drm] Using GuC firmware (70.5) from i915/dg2_guc_70.bin
[ 486.198192] xe 0000:03:00.0: [drm] HuC disabled
[ 486.241959] xe 0000:03:00.0: [drm] ccs0 fused off
[ 486.241964] xe 0000:03:00.0: [drm] ccs2 fused off
[ 486.241965] xe 0000:03:00.0: [drm] ccs3 fused off
[ 486.242509] xe REG[0x223a8-0x223af]: allow read access
[ 486.242606] xe REG[0x1c03a8-0x1c03af]: allow read access
[ 486.242708] xe REG[0x1d03a8-0x1d03af]: allow read access
[ 486.242826] xe REG[0x1c83a8-0x1c83af]: allow read access
[ 486.242945] xe REG[0x1d83a8-0x1d83af]: allow read access
[ 486.243033] xe REG[0x1c3a8-0x1c3af]: allow read access
[ 486.306291] [drm] Initialized xe 1.1.0 20201103 for 0000:03:00.0 on minor 0
[ 486.309344] insmod (3290) used greatest stack depth: 10936 bytes left
[ 487.559809] xe 0000:03:00.0: [drm] GT0: suspended
[ 500.096224] [IGT] perf: executing
[ 502.830435] pcieport 0000:01:00.0: not ready 1023ms after resume; giving up
[ 502.832901] pcieport 0000:01:00.0: Unable to change power state from D3cold to D0, device inaccessible
[ 502.835939] pcieport 0000:02:01.0: Unable to change power state from D3cold to D0, device inaccessible
[ 502.836769] pcieport 0000:02:04.0: Unable to change power state from D3cold to D0, device inaccessible
[ 505.070434] xe 0000:03:00.0: not ready 1023ms after resume; giving up
[ 505.071074] xe 0000:03:00.0: Unable to change power state from D3cold to D0, device inaccessible
[ 505.087125] snd_hda_intel 0000:04:00.0: not ready 1023ms after resume; giving up
[ 505.087154] snd_hda_intel 0000:04:00.0: Unable to change power state from D3cold to D0, device inaccessible
[ 505.183156] xe 0000:03:00.0: Unable to change power state from D3cold to D0, device inaccessible
[ 505.242684] xe 0000:03:00.0: [drm] Force wake domain (0) failed to ack sleep, ret=-110
[ 505.296974] snd_hda_intel 0000:04:00.0: CORB reset timeout#2, CORBRP = 65535
[ 505.302246] xe 0000:03:00.0: [drm] Force wake domain (1) failed to ack sleep, ret=-110
[ 505.362158] xe 0000:03:00.0: [drm] Force wake domain (3) failed to ack sleep, ret=-110
[ 505.423158] xe 0000:03:00.0: [drm] Force wake domain (5) failed to ack sleep, ret=-110
[ 505.484157] xe 0000:03:00.0: [drm] Force wake domain (11) failed to ack sleep, ret=-110
[ 505.543101] xe 0000:03:00.0: [drm] Force wake domain (12) failed to ack sleep, ret=-110
[ 505.543139] ------------[ cut here ]------------
[ 505.543141] WARNING: CPU: 1 PID: 3328 at drivers/gpu/drm/xe/xe_oa.c:1913 xe_oa_timestamp_frequency+0xca/0xd0 [xe]
[ 505.543173] Modules linked in: xe(O) gpu_sched drm_buddy drm_suballoc_helper drm_ttm_helper ttm nfnetlink br_netfilter overlay mei_pxp x86_pkg_temp_thermal mei_hdcp coretemp kvm_intel snd_hda_codec_h
dmi snd_hda_codec_realtek snd_hda_codec_generic ledtrig_audio snd_hda_intel snd_intel_dspcfg snd_hda_codec snd_hwdep snd_hda_core wmi_bmof mei_gsc mei_me snd_pcm mei fuse ip_tables x_tables crct10dif_pc
lmul crc32_pclmul ghash_clmulni_intel e1000e i2c_i801 i2c_smbus ptp pps_core wmi [last unloaded: prime_numbers]
[ 505.543220] CPU: 1 PID: 3328 Comm: perf Tainted: G O 6.3.0+ #2
[ 505.543222] Hardware name: Intel Corporation CoffeeLake Client Platform/CoffeeLake S UDIMM RVP, BIOS CNLSFWR1.R00.X220.B00.2103302221 03/30/2021
[ 505.543224] RIP: 0010:xe_oa_timestamp_frequency+0xca/0xd0 [xe]
[ 505.543252] Code: 5c 8b 40 10 f7 d1 41 5d 83 e1 03 d3 e0 c3 cc cc cc cc 41 8b 84 24 4c 02 00 00 05 00 0d 00 00 25 ff ff 3f 00 eb ab 0f 0b eb 80 <0f> 0b eb bb 66 90 90 90 90 90 90 90 90 90 90 90 90 90
90 90 90 90
[ 505.543255] RSP: 0018:ffffc90005617d58 EFLAGS: 00010282
[ 505.543257] RAX: 00000000ffffff92 RBX: ffff88810f798000 RCX: ffffc90005617c4c
[ 505.543259] RDX: 0000000000000000 RSI: ffffffff8268031a RDI: ffffffff826a5b09
[ 505.543261] RBP: ffff88813fd88050 R08: 0000000000000000 R09: 00000000fffeffff
[ 505.543262] R10: 0000000000000000 R11: ffff88846de6fac0 R12: 00000000ffffffff
[ 505.543264] R13: ffff88810f79a268 R14: 0000000000000000 R15: ffff88810f798000
[ 505.543265] FS: 00007fe0dc224c00(0000) GS:ffff88845da80000(0000) knlGS:0000000000000000
[ 505.543267] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 505.543269] CR2: 000055c202d18fb0 CR3: 00000001302d8006 CR4: 00000000003706e0
[ 505.543271] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
[ 505.543272] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
[ 505.543274] Call Trace:
[ 505.543276] <TASK>
[ 505.543279] query_gts+0xd9/0x1f0 [xe]
[ 505.543309] ? __pfx_xe_query_ioctl+0x10/0x10 [xe]
[ 505.543337] drm_ioctl_kernel+0xb4/0x150
[ 505.543343] drm_ioctl+0x214/0x440
[ 505.543347] ? __pfx_xe_query_ioctl+0x10/0x10 [xe]
[ 505.543376] ? __rseq_handle_notify_resume+0x48e/0x5c0
[ 505.543382] ? xfd_validate_state+0x1d/0x80
[ 505.543387] __x64_sys_ioctl+0x89/0xb0
[ 505.543391] do_syscall_64+0x3c/0x90
[ 505.543396] entry_SYSCALL_64_after_hwframe+0x72/0xdc
[ 505.543399] RIP: 0033:0x7fe0de11aaff
next prev parent reply other threads:[~2023-06-30 6:22 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-26 10:50 [Intel-xe] [PATCH v12 00/13] xe_device_mem_access fixes and related bits Matthew Auld
2023-06-26 10:50 ` [Intel-xe] [PATCH v12 01/13] drm/xe: fix xe_device_mem_access_get() races Matthew Auld
2023-06-30 15:22 ` Gupta, Anshuman
2023-07-04 11:25 ` Matthew Auld
2023-07-04 15:29 ` Gupta, Anshuman
2023-07-04 16:00 ` Matthew Auld
2023-07-11 9:00 ` Gupta, Anshuman
2023-07-11 11:06 ` Matthew Auld
2023-07-11 17:56 ` Gupta, Anshuman
2023-06-26 10:50 ` [Intel-xe] [PATCH v12 02/13] drm/xe/vm: tidy up xe_runtime_pm usage Matthew Auld
2023-06-26 10:50 ` [Intel-xe] [PATCH v12 03/13] drm/xe/debugfs: grab mem_access around forcewake Matthew Auld
2023-06-26 10:50 ` [Intel-xe] [PATCH v12 04/13] drm/xe/guc_pc: add missing mem_access for freq_rpe_show Matthew Auld
2023-06-27 6:53 ` Gupta, Anshuman
2023-06-27 8:20 ` Matthew Auld
2023-06-27 10:14 ` Gupta, Anshuman
2023-06-26 10:50 ` [Intel-xe] [PATCH v12 05/13] drm/xe/mmio: grab mem_access in xe_mmio_ioctl Matthew Auld
2023-06-26 10:50 ` [Intel-xe] [PATCH v12 06/13] drm/xe: ensure correct access_put ordering Matthew Auld
2023-06-26 10:50 ` [Intel-xe] [PATCH v12 07/13] drm/xe/pci: wrap probe with mem_access Matthew Auld
2023-06-26 10:50 ` [Intel-xe] [PATCH v12 08/13] drm/xe/display: use mem_access underneath Matthew Auld
2023-06-28 9:51 ` Gupta, Anshuman
2023-06-29 9:19 ` Matthew Auld
2023-06-26 10:50 ` [Intel-xe] [PATCH v12 09/13] drm/xe/mmio: enforce xe_device_assert_mem_access Matthew Auld
2023-06-26 10:50 ` [Intel-xe] [PATCH v12 10/13] drm/xe: drop xe_device_mem_access_get() from guc_ct_send Matthew Auld
2023-06-26 10:50 ` [Intel-xe] [PATCH v12 11/13] drm/xe/ggtt: prime ggtt->lock against FS_RECLAIM Matthew Auld
2023-06-26 10:50 ` [Intel-xe] [PATCH v12 12/13] drm/xe: drop xe_device_mem_access_get() from invalidation_vma Matthew Auld
2023-06-26 10:50 ` [Intel-xe] [PATCH v12 13/13] drm/xe: add lockdep annotation for xe_device_mem_access_get() Matthew Auld
2023-06-26 12:55 ` [Intel-xe] ✓ CI.Patch_applied: success for xe_device_mem_access fixes and related bits (rev2) Patchwork
2023-06-26 12:56 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-06-26 12:57 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-06-26 13:01 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-06-26 13:01 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-06-26 13:02 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-06-26 13:46 ` [Intel-xe] ○ CI.BAT: info " Patchwork
2023-06-30 6:21 ` Dixit, Ashutosh [this message]
2023-06-30 11:07 ` [Intel-xe] [PATCH v12 00/13] xe_device_mem_access fixes and related bits Matthew Auld
2023-06-30 16:59 ` Dixit, Ashutosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87edlt5v2d.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.auld@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox