Re: [Intel-xe] [PATCH 18/21] drm/xe/uapi: More OA uapi fixes/additions

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Tue, 19 Sep 2023 09:10:46 -0700, Ashutosh Dixit wrote:
>
> +/**
> + * struct drm_xe_query_oa_info - describe OA units
> + *
> + * If a query is made with a struct drm_xe_device_query where .query
> + * is equal to DRM_XE_DEVICE_QUERY_OA_INFO, then the reply uses struct
> + * drm_xe_query_oa_info in .data.
> + */
> +struct drm_xe_query_oa_info {
> +	/** @extensions: Pointer to the first extension struct, if any */
> +	__u64 extensions;
> +
> +	/** @oa_unit_count: number of OA units returned in oau[] */
> +	__u32 oa_unit_count;
> +
> +	/** @pad: MBZ */
> +	__u32 pad;

After discussions with Umesh, we will add a 'capabilities' bitmask here.

Umesh, could you please see if anything else should be added to this
struct?

Thanks.
--
Ashutosh

> +
> +	/** @reserved: MBZ */
> +	__u64 reserved[4];
> +
> +	/** @oau: OA units returned for this device */
> +	struct drm_xe_query_oa_unit {
> +		/** @oa_unit_id: OA unit ID */
> +		__u16 oa_unit_id;
> +
> +		/** @gt_id: GT ID for this OA unit */
> +		__u16 gt_id;
> +
> +		/** @pad: MBZ */
> +		__u32 pad;
> +
> +		/** @oa_timestamp_freq: OA timestamp freq */
> +		__u64 oa_timestamp_freq;
> +
> +		/** @reserved: MBZ */
> +		__u64 reserved[4];
> +
> +		/** @eci: engines attached to this OA unit */
> +		struct drm_xe_engine_class_instance eci[];
> +	} oau[];
> +};