From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: francois.dugast@intel.com,
Lucas De Marchi <lucas.demarchi@intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [PATCH] drm/xe/pmu/uapi: Remove PMU group busyness events from uapi
Date: Sat, 09 Dec 2023 14:58:26 -0800 [thread overview]
Message-ID: <87jzpnhtkd.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <87o7f0i2hs.wl-ashutosh.dixit@intel.com>
On Fri, 08 Dec 2023 17:33:19 -0800, Dixit, Ashutosh wrote:
>
> On Fri, 08 Dec 2023 16:02:33 -0800, Ashutosh Dixit wrote:
> >
> > PMU group busyness uapi is likely to change in the future. Till the uapi is
> > decided remove the uapi from xe_drm.h. To not break the build retain the
> > events internally in xe_pmu.c for now.
>
> This gets the job done of getting the PMU stuff out of the uapi, but not
> sure if moving the defines in xe_pmu.c is ugly? The other easy option is to
> just delete everything (maybe drop all PMU patches in a rebase). Later add
> it back when some valid PMU stuff is added again.
>
> Deleting the uapi but retaining the PMU infrastructure is a chore. I'd say
> do something like this patch, or delete everything and start over.
Deleting everything is done here:
https://patchwork.freedesktop.org/series/127598/
next prev parent reply other threads:[~2023-12-09 22:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-09 0:02 [PATCH] drm/xe/pmu/uapi: Remove PMU group busyness events from uapi Ashutosh Dixit
2023-12-09 1:20 ` ✓ CI.Patch_applied: success for drm/xe/pmu/uapi: Remove PMU group busyness events from uapi (rev2) Patchwork
2023-12-09 1:20 ` ✓ CI.checkpatch: " Patchwork
2023-12-09 1:22 ` ✓ CI.KUnit: " Patchwork
2023-12-09 1:29 ` ✓ CI.Build: " Patchwork
2023-12-09 1:29 ` ✓ CI.Hooks: " Patchwork
2023-12-09 1:31 ` ✓ CI.checksparse: " Patchwork
2023-12-09 1:33 ` [PATCH] drm/xe/pmu/uapi: Remove PMU group busyness events from uapi Dixit, Ashutosh
2023-12-09 22:58 ` Dixit, Ashutosh [this message]
2023-12-09 2:09 ` ✗ CI.BAT: failure for drm/xe/pmu/uapi: Remove PMU group busyness events from uapi (rev2) Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-12-09 0:01 [PATCH] drm/xe/pmu/uapi: Remove PMU group busyness events from uapi Ashutosh Dixit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzpnhtkd.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=francois.dugast@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox