Re: [PATCH v2 00/14] drm/i915: sagv/bw cleanup

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 26 Mar 2025, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Continue improving the code around sagv/bw vs.
> watermarks. A lot of the details get better encapsulated
> within intel_bw.c and the complicated interactions between
> different parts of the code are somewhat reduced.

On the series,

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

with the caveat that my understanding of all the subtle bw stuff details
in patches 6-14 is admittedly weak. The patches make sense, and I didn't
spot anything obviously wrong, but there may well be cases that I just
couldn't think of.

BR,
Jani.


>
> v2: Rebase due to intel_display conversions
>
> Ville Syrjälä (14):
>   drm/i915: Drop the cached per-pipe min_cdclk[] from bw state
>   drm/i915: s/intel_crtc_bw/intel_dbuf_bw/
>   drm/i915: Extract intel_dbuf_bw_changed()
>   drm/i915: Pass intel_dbuf_bw to skl_*_calc_dbuf_bw() explicitly
>   drm/i915: Avoid triggering unwanted cdclk changes due to dbuf
>     bandwidth changes
>   drm/i915: Do more bw readout
>   drm/i915: Flag even inactive crtcs as "inherited"
>   drm/i915: Drop force_check_qgv
>   drm/i915: Extract intel_bw_modeset_checks()
>   drm/i915: Extract intel_bw_check_sagv_mask()
>   drm/i915: Make intel_bw_check_sagv_mask() internal to intel_bw.c
>   drm/i915: Make intel_bw_modeset_checks() internal to
>     intel_bw_atomic_check()
>   drm/i915: Skip bw stuff if per-crtc sagv state doesn't change
>   drm/i915: Eliminate intel_compute_sagv_mask()
>
>  drivers/gpu/drm/i915/display/intel_bw.c       | 187 ++++++++++++++----
>  drivers/gpu/drm/i915/display/intel_bw.h       |   9 +-
>  drivers/gpu/drm/i915/display/intel_cdclk.c    |   4 +
>  drivers/gpu/drm/i915/display/intel_display.c  |   5 +-
>  .../drm/i915/display/intel_modeset_setup.c    |  22 +--
>  drivers/gpu/drm/i915/display/skl_watermark.c  | 112 ++++-------
>  drivers/gpu/drm/i915/display/skl_watermark.h  |   1 +
>  7 files changed, 202 insertions(+), 138 deletions(-)

-- 
Jani Nikula, Intel