Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe: Nuke xe's copy of intel_fbdev_fb.h
@ 2024-05-06 18:33 Ville Syrjala
  2024-05-06 20:54 ` ✓ CI.Patch_applied: success for " Patchwork
                   ` (8 more replies)
  0 siblings, 9 replies; 13+ messages in thread
From: Ville Syrjala @ 2024-05-06 18:33 UTC (permalink / raw)
  To: intel-xe; +Cc: intel-gfx

From: Ville Syrjälä <ville.syrjala@linux.intel.com>

For some reason xe and i915 each have an identical (fortunately)
copy of intel_fbdev_fb.h. The xe copy actually only gets included
by xe's intel_fbdev_fb.c, and the i915 copy by everyone else,
include intel_fbdev.c which is the actual caller of the
functions declared in the header.

This means the xe and i915 headers are free to define/declare
completely incompatible things and the build would still succeed
as long as the symbol names match.

That is not a good thing, so let's nuke xe's copy of the header
so that everyone will use the same header, and be forced to
agree on the same API/ABI.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
---
 drivers/gpu/drm/xe/display/intel_fbdev_fb.h | 21 ---------------------
 1 file changed, 21 deletions(-)
 delete mode 100644 drivers/gpu/drm/xe/display/intel_fbdev_fb.h

diff --git a/drivers/gpu/drm/xe/display/intel_fbdev_fb.h b/drivers/gpu/drm/xe/display/intel_fbdev_fb.h
deleted file mode 100644
index ea186772e0bb..000000000000
--- a/drivers/gpu/drm/xe/display/intel_fbdev_fb.h
+++ /dev/null
@@ -1,21 +0,0 @@
-/* SPDX-License-Identifier: MIT */
-/*
- * Copyright © 2023 Intel Corporation
- */
-
-#ifndef __INTEL_FBDEV_FB_H__
-#define __INTEL_FBDEV_FB_H__
-
-struct drm_fb_helper;
-struct drm_fb_helper_surface_size;
-struct drm_i915_gem_object;
-struct drm_i915_private;
-struct fb_info;
-struct i915_vma;
-
-struct drm_framebuffer *intel_fbdev_fb_alloc(struct drm_fb_helper *helper,
-			 struct drm_fb_helper_surface_size *sizes);
-int intel_fbdev_fb_fill_info(struct drm_i915_private *i915, struct fb_info *info,
-			      struct drm_i915_gem_object *obj, struct i915_vma *vma);
-
-#endif
-- 
2.43.2


^ permalink raw reply related	[flat|nested] 13+ messages in thread

end of thread, other threads:[~2024-05-10  9:29 UTC | newest]

Thread overview: 13+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-05-06 18:33 [PATCH] drm/xe: Nuke xe's copy of intel_fbdev_fb.h Ville Syrjala
2024-05-06 20:54 ` ✓ CI.Patch_applied: success for " Patchwork
2024-05-06 20:54 ` ✗ CI.checkpatch: warning " Patchwork
2024-05-06 20:55 ` ✓ CI.KUnit: success " Patchwork
2024-05-06 21:07 ` ✓ CI.Build: " Patchwork
2024-05-06 21:13 ` ✓ CI.Hooks: " Patchwork
2024-05-06 21:23 ` ✓ CI.checksparse: " Patchwork
2024-05-06 22:02 ` ✓ CI.BAT: " Patchwork
2024-05-07  2:12 ` ✗ CI.FULL: failure " Patchwork
2024-05-07  8:53 ` [PATCH] " Jani Nikula
2024-05-08 19:52   ` Ville Syrjälä
2024-05-08 20:54     ` Lucas De Marchi
2024-05-10  9:29     ` Jani Nikula

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox