Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] drm/i915/dmc: fix assert_dmc_loaded WARN during async firmware load
@ 2026-05-08 18:13 James Xiong
  2026-05-08 18:20 ` ✓ CI.KUnit: success for drm/i915/dmc: fix assert_dmc_loaded WARN during async firmware load (rev2) Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 10+ messages in thread
From: James Xiong @ 2026-05-08 18:13 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: gustavo.sousa, jani.nikula, James Xiong

During driver probe, DMC firmware is loaded asynchronously via a
workqueue. There is a race between parse_dmc_fw() setting the payload
pointer (making has_dmc_id_fw() return true) and intel_dmc_load_program()
writing the firmware to hardware registers. If the probe thread calls
intel_dmc_enable_pipe() -> assert_dmc_loaded() in this window via
intel_modeset_setup_hw_state(), it sees parsed payload but stale HW
registers, triggering a ~20% intermittent WARNING on ADL-N warm boot.

v2: Fix by calling intel_dmc_wait_fw_load() in
    intel_modeset_setup_hw_state() before iterating the CRTCs (Gustavo
    Sousa).

v3: Move intel_dmc_wait_fw_load() into intel_dmc_enable_pipe() itself
    so the function is self-contained (Jani Nikula, Gustavo Sousa).

Signed-off-by: James Xiong <james.xiong@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dmc.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dmc.c b/drivers/gpu/drm/i915/display/intel_dmc.c
index 0df4f42ba3e3..4151eae92744 100644
--- a/drivers/gpu/drm/i915/display/intel_dmc.c
+++ b/drivers/gpu/drm/i915/display/intel_dmc.c
@@ -786,7 +786,12 @@ void intel_dmc_enable_pipe(const struct intel_crtc_state *crtc_state)
 	enum pipe pipe = crtc->pipe;
 	enum intel_dmc_id dmc_id = PIPE_TO_DMC_ID(pipe);
 
-	if (!is_valid_dmc_id(dmc_id) || !has_dmc_id_fw(display, dmc_id))
+	if (!is_valid_dmc_id(dmc_id))
+		return;
+
+	intel_dmc_wait_fw_load(display);
+
+	if (!has_dmc_id_fw(display, dmc_id))
 		return;
 
 	if (!can_enable_pipedmc(crtc_state)) {
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread
end of thread, other threads:[~2026-05-12  8:25 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-08 18:13 [PATCH v3] drm/i915/dmc: fix assert_dmc_loaded WARN during async firmware load James Xiong
2026-05-08 18:20 ` ✓ CI.KUnit: success for drm/i915/dmc: fix assert_dmc_loaded WARN during async firmware load (rev2) Patchwork
2026-05-08 19:30 ` ✓ Xe.CI.BAT: " Patchwork
2026-05-09  7:06 ` ✓ Xe.CI.FULL: " Patchwork
2026-05-11 12:20 ` [PATCH v3] drm/i915/dmc: fix assert_dmc_loaded WARN during async firmware load Gustavo Sousa
2026-05-11 12:39   ` Imre Deak
2026-05-11 12:50     ` Gustavo Sousa
2026-05-11 12:52       ` Gustavo Sousa
2026-05-11 12:59       ` Imre Deak
2026-05-12  8:25         ` Jani Nikula

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox