Re: [PATCH] drm/i915: use fine grained -Woverride-init disable

[Jani Nikula <jani.nikula@intel.com>]

On Thu, 28 Mar 2024, "Arnd Bergmann" <arnd@arndb.de> wrote:
> On Thu, Mar 28, 2024, at 11:24, Jani Nikula wrote:
>> Use localized __diag_push(), __diag_ignore_all() with rationale, and
>> __diag_pop() for specific initializations instead of blanket disabling
>> of -Woverride-init across several files.
>>
>> Note that we've tried this before with commit 88e9664434c9 ("drm/i915:
>> use localized __diag_ignore_all() instead of per file") and reverted in
>> commit 290d16104575 ("Revert "drm/i915: use localized
>> __diag_ignore_all() instead of per file""). The issue turned out to be
>> in __diag_ignore_all() and it was fixed by commit 689b097a06ba
>> ("compiler-gcc: Suppress -Wmissing-prototypes warning for all supported
>> GCC"). So we should be able to pull this off now.
>>
>> Cc: "Arnd Bergmann" <arnd@arndb.de>
>> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Looks good to me,
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>

Thanks! I'll take this via drm-intel-next for v6.10. Up to you what to
do with your patch [1], either drop the i915 and xe changes, or we can
handle the trivial conflict too if keeping the changes helps you
somehow.

BR,
Jani.


[1] https://lore.kernel.org/all/20240326144741.3094687-2-arnd@kernel.org/

-- 
Jani Nikula, Intel