From: "Arnd Bergmann" <arnd@arndb.de>
To: "Jani Nikula" <jani.nikula@intel.com>,
intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: "Lucas De Marchi" <lucas.demarchi@intel.com>
Subject: Re: [PATCH] drm/i915: use fine grained -Woverride-init disable
Date: Thu, 28 Mar 2024 11:38:16 +0100 [thread overview]
Message-ID: <b9138bc4-61e4-476a-9aa5-8842235bce2e@app.fastmail.com> (raw)
In-Reply-To: <20240328102455.944131-1-jani.nikula@intel.com>
On Thu, Mar 28, 2024, at 11:24, Jani Nikula wrote:
> Use localized __diag_push(), __diag_ignore_all() with rationale, and
> __diag_pop() for specific initializations instead of blanket disabling
> of -Woverride-init across several files.
>
> Note that we've tried this before with commit 88e9664434c9 ("drm/i915:
> use localized __diag_ignore_all() instead of per file") and reverted in
> commit 290d16104575 ("Revert "drm/i915: use localized
> __diag_ignore_all() instead of per file""). The issue turned out to be
> in __diag_ignore_all() and it was fixed by commit 689b097a06ba
> ("compiler-gcc: Suppress -Wmissing-prototypes warning for all supported
> GCC"). So we should be able to pull this off now.
>
> Cc: "Arnd Bergmann" <arnd@arndb.de>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Looks good to me,
Acked-by: Arnd Bergmann <arnd@arndb.de>
next prev parent reply other threads:[~2024-03-28 10:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 10:24 [PATCH] drm/i915: use fine grained -Woverride-init disable Jani Nikula
2024-03-28 10:38 ` Arnd Bergmann [this message]
2024-03-28 10:46 ` Jani Nikula
2024-03-28 10:52 ` Arnd Bergmann
2024-04-02 8:11 ` Jani Nikula
2024-03-28 10:42 ` ✓ CI.Patch_applied: success for " Patchwork
2024-03-28 10:42 ` ✗ CI.checkpatch: warning " Patchwork
2024-03-28 10:43 ` ✓ CI.KUnit: success " Patchwork
2024-03-28 10:58 ` ✓ CI.Build: " Patchwork
2024-03-28 11:00 ` ✓ CI.Hooks: " Patchwork
2024-03-28 11:01 ` ✗ CI.checksparse: warning " Patchwork
2024-03-28 11:31 ` ✓ CI.BAT: success " Patchwork
2024-03-28 13:16 ` [PATCH] " Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9138bc4-61e4-476a-9aa5-8842235bce2e@app.fastmail.com \
--to=arnd@arndb.de \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
--cc=lucas.demarchi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox