From: "Dixit, Ashutosh" <ashutosh.dixit@intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Francois.Dugast@intel.com, intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH] drm/xe/uapi: Use common drm_xe_ext_set_property extension
Date: Sat, 09 Sep 2023 08:59:34 -0700 [thread overview]
Message-ID: <87o7ibqqvt.wl-ashutosh.dixit@intel.com> (raw)
In-Reply-To: <ZPyNl+qH+ycopGlE@intel.com>
On Sat, 09 Sep 2023 08:21:59 -0700, Rodrigo Vivi wrote:
>
Hi Rodrigo,
> On Sat, Sep 09, 2023 at 11:15:20AM -0400, Rodrigo Vivi wrote:
> > On Fri, Sep 08, 2023 at 10:21:53PM -0700, Ashutosh Dixit wrote:
> > > There really is no difference between 'struct drm_xe_ext_vm_set_property'
> > > and 'struct drm_xe_ext_exec_queue_set_property', they are extensions which
> > > specify a <property, value> pair. Replace the two extensions with a single
> > > common 'struct drm_xe_ext_set_property' extension. The rationale is that
> > > rather than have each XE module (including future modules) invent their own
> > > property/value extensions, all XE modules use a common set_property
> > > extension when possible.
> >
> > What about just killing this entirely?
> > https://lore.kernel.org/all/20230908203302.449041-2-rodrigo.vivi@intel.com/
>
> hmm... or maybe what we want is a mix of your patch and mine.
> Let's use yours to kill the drm_xe_ext_exec_queue_set_property
> in favor of a generic drm_xe_ext_set_property
> and then mine goes on top killing just the
> XE_VM_PROPERTY_BIND_OP_ERROR_CAPTURE_ADDRESS operation.
>
> thoughts? I can integrate and carry your patch in my series if you are
> okay with that.
Yes, please go ahead. Fwiw I think a generic drm_xe_ext_set_property will
be useful in the future, e.g. I am thinking of using it for OA.
Thanks.
--
Ashutosh
prev parent reply other threads:[~2023-09-09 15:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-09 5:21 [Intel-xe] [PATCH] drm/xe/uapi: Use common drm_xe_ext_set_property extension Ashutosh Dixit
2023-09-09 5:24 ` [Intel-xe] ✓ CI.Patch_applied: success for " Patchwork
2023-09-09 5:24 ` [Intel-xe] ✓ CI.checkpatch: " Patchwork
2023-09-09 5:25 ` [Intel-xe] ✓ CI.KUnit: " Patchwork
2023-09-09 5:32 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-09-09 5:33 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-09-09 5:34 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-09-09 6:07 ` [Intel-xe] ✓ CI.BAT: " Patchwork
2023-09-09 15:15 ` [Intel-xe] [PATCH] " Rodrigo Vivi
2023-09-09 15:21 ` Rodrigo Vivi
2023-09-09 15:59 ` Dixit, Ashutosh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o7ibqqvt.wl-ashutosh.dixit@intel.com \
--to=ashutosh.dixit@intel.com \
--cc=Francois.Dugast@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox