Re: [PATCH] fixup! drm/xe/oa: Add OAR support

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Wed, 17 Jul 2024 22:48:48 -0700, Ohad Sharabi wrote:
>

Hi Ohad,

> The current implementation uses static CS codes instead of common.
>
> Signed-off-by: Ohad Sharabi <osharabi@habana.ai>
> ---
>  drivers/gpu/drm/xe/xe_oa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c
> index 6d69f751bf78..3ef92eb8fbb1 100644
> --- a/drivers/gpu/drm/xe/xe_oa.c
> +++ b/drivers/gpu/drm/xe/xe_oa.c
> @@ -641,7 +641,7 @@ static void xe_oa_store_flex(struct xe_oa_stream *stream, struct xe_lrc *lrc,
>	u32 offset = xe_bo_ggtt_addr(lrc->bo);
>
>	do {
> -		bb->cs[bb->len++] = MI_STORE_DATA_IMM | BIT(22) /* GGTT */ | 2;
> +		bb->cs[bb->len++] = MI_STORE_DATA_IMM | MI_SDI_GGTT | MI_SDI_NUM_DW(1);
>		bb->cs[bb->len++] = offset + flex->offset * sizeof(u32);
>		bb->cs[bb->len++] = 0;
>		bb->cs[bb->len++] = flex->value;

The patch is fine. However, we don't have fixup patches upstream. So please
change the patch title and description to something like:

"
drm/xe/oa: Don't use hardcoded values

The current implementation uses hardcoded values instead of common defines.
"

Please resend the patch with this change, I can review and merge it.

Thanks.
--
Ashutosh