Re: [PATCH v3 5/8] drm/xe: Call xe_wa_process_device_oob() after xe_sriov_probe_early()

[Gustavo Sousa <gustavo.sousa@intel.com>]

Michal Wajdeczko <michal.wajdeczko@intel.com> writes:

> On 3/9/2026 9:07 PM, Gustavo Sousa wrote:
>> We will need to use FUNC(xe_rtp_match_not_sriov_vf) in an upcoming
>> device OOB workaround and we need the SRIOV mode already defined by the
>> time that workaround check is done.  Move the call to
>> xe_wa_process_device_oob() to happen after  xe_sriov_probe_early() to
>> allow usage of FUNC(xe_rtp_match_not_sriov_vf).
>> 
>> Signed-off-by: Gustavo Sousa <gustavo.sousa@intel.com>
>> ---
>>  drivers/gpu/drm/xe/xe_device.c | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>> 
>> diff --git a/drivers/gpu/drm/xe/xe_device.c b/drivers/gpu/drm/xe/xe_device.c
>> index 3462645ca13c..5651bcdc6752 100644
>> --- a/drivers/gpu/drm/xe/xe_device.c
>> +++ b/drivers/gpu/drm/xe/xe_device.c
>> @@ -699,15 +699,15 @@ int xe_device_probe_early(struct xe_device *xe)
>>  {
>>  	int err;
>>  
>> -	xe_wa_device_init(xe);
>> -	xe_wa_process_device_oob(xe);
>> -
>>  	err = xe_mmio_probe_early(xe);
>>  	if (err)
>>  		return err;
>>  
>>  	xe_sriov_probe_early(xe);
>>  
>> +	xe_wa_device_init(xe);
>> +	xe_wa_process_device_oob(xe);
>
> maybe it would be better to move wa_init after below vf_update call
> to keep SRIOV related functions together ? also the vf_update will
> clear some feature flags, maybe it's also better to do that before
> any wa processing?

I don't think there are device OOB workarounds that need that
information right now, but, yeah, keeping SRIOV-related functions
together sounds fair.

--
Gustavo Sousa

>
>> +
>>  	if (IS_SRIOV_VF(xe))
>>  		vf_update_device_info(xe);
>>  
>>