Re: [PATCH 0/9] drm/i915/dp: clean up DP testing

[Jani Nikula <jani.nikula@intel.com>]

On Fri, 20 Sep 2024, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Fri, Sep 20, 2024 at 02:56:42PM +0300, Jani Nikula wrote:
>> Whenever I look at doing anything in intel_dp.c I think it's grown too
>> big. It's over 7k lines.
>> 
>> The DP test functionality is fairly isolated, and mostly irrelevant for
>> normal operation. Move it all to its own file. This reduces intel_dp.c
>> by about 500 lines, and intel_display_debugfs.c by about 200 lines. And
>> intel_dp->compliance is now fully handled within intel_dp_test.c.
>> 
>> BR,
>> Jani.
>> 
>> Jani Nikula (9):
>>   drm/i915/dp: split out intel_dp_test.[ch] to a dedicated file
>>   drm/i915/dp: fix style issues in intel_dp_test.c
>>   drm/i915/dp: convert intel_dp_test.c struct intel_display
>>   drm/i915/dp: clean up intel_dp_test.[ch] interface
>>   drm/i915/dp: move DP test debugfs files next to the functionality
>>   drm/i915/dp: fix style issues in DP test debugfs
>>   drm/i915/display: remove the loop in fifo underrun debugfs file
>>     creation
>>   drm/i915/dp: convert DP test debugfs to struct intel_display
>>   drm/i915/dp: add intel_dp_test_reset() and intel_dp_test_short_pulse()
>
> Gave this a quick once over, didn't see anything obviously wrong.
>
> Series is
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Thanks, pushed to din.

BR,
Jani.

>
>> 
>>  drivers/gpu/drm/i915/Makefile                 |   1 +
>>  drivers/gpu/drm/i915/display/g4x_dp.c         |   7 +-
>>  drivers/gpu/drm/i915/display/intel_ddi.c      |   7 +-
>>  .../drm/i915/display/intel_display_debugfs.c  | 214 +----
>>  drivers/gpu/drm/i915/display/intel_dp.c       | 520 +-----------
>>  drivers/gpu/drm/i915/display/intel_dp.h       |   9 +-
>>  drivers/gpu/drm/i915/display/intel_dp_mst.c   |   5 +-
>>  drivers/gpu/drm/i915/display/intel_dp_test.c  | 765 ++++++++++++++++++
>>  drivers/gpu/drm/i915/display/intel_dp_test.h  |  23 +
>>  drivers/gpu/drm/xe/Makefile                   |   1 +
>>  10 files changed, 816 insertions(+), 736 deletions(-)
>>  create mode 100644 drivers/gpu/drm/i915/display/intel_dp_test.c
>>  create mode 100644 drivers/gpu/drm/i915/display/intel_dp_test.h
>> 
>> -- 
>> 2.39.2

-- 
Jani Nikula, Intel