Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/xe/lrc: Fix math in LRC offset comments
@ 2026-11-16 22:50 Matt Roper
  2026-11-16 23:16 ` ✓ CI.KUnit: success for " Patchwork
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Matt Roper @ 2026-11-16 22:50 UTC (permalink / raw)
  To: intel-xe; +Cc: matthew.d.roper

PREEMPTION_STATUS in the Xe2 RCS LRC starts at offset 0x39 and requires
two dwords of space (offset + value), so the next item in the LRC starts
at 0x3b, not 0x41 (it appears the number was treated as decimal rather
than hex when the comment was first written).  Adjust the remaining
offset comments to show the proper values.

No functional impact; these comments are just for convenience and don't
relate to any in-driver logic.

Bspec: 65182
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/xe/xe_lrc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c
index 8e4f767d7f59..54d50b1b28eb 100644
--- a/drivers/gpu/drm/xe/xe_lrc.c
+++ b/drivers/gpu/drm/xe/xe_lrc.c
@@ -563,9 +563,9 @@ static const u8 xe2_rcs_offsets[] = {
 	REG16(0x5a8),           /* [0x37] CONTEXT_SCHEDULING_ATTRIBUTES */
 	REG16(0x5ac),           /* [0x39] PREEMPTION_STATUS */
 
-	NOP(6),                 /* [0x41] */
-	LRI(1, 0),              /* [0x47] */
-	REG(0x0c8),             /* [0x48] R_PWR_CLK_STATE */
+	NOP(6),                 /* [0x3b] */
+	LRI(1, 0),              /* [0x41] */
+	REG(0x0c8),             /* [0x42] R_PWR_CLK_STATE */
 
 	0
 };
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-11-17 13:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-11-16 22:50 [PATCH] drm/xe/lrc: Fix math in LRC offset comments Matt Roper
2026-11-16 23:16 ` ✓ CI.KUnit: success for " Patchwork
2026-11-16 23:58 ` ✓ Xe.CI.BAT: " Patchwork
2026-11-17 12:49 ` [PATCH] " Gustavo Sousa
2026-11-17 13:05 ` ✗ Xe.CI.FULL: failure for " Patchwork

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox