Re: [PATCH v2] drm/xe/oa: Allow reading after disabling OA stream

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Mon, 16 Mar 2026 21:42:50 -0700, Nerlige Ramappa, Umesh wrote:
>
> Have mail client problems, so sending from Outlook
>
> > -----Original Message-----
> > From: Dixit, Ashutosh <ashutosh.dixit@intel.com>
> > Sent: Friday, March 13, 2026 11:07 AM
> > To: intel-xe@lists.freedesktop.org
> > Cc: Nerlige Ramappa, Umesh <umesh.nerlige.ramappa@intel.com>
> > Subject: [PATCH v2] drm/xe/oa: Allow reading after disabling OA stream
> >
> > Some OA data might be present in the OA buffer when OA stream is disabled.
> > Allow UMD's to retrieve this data, so that all data till the point when OA stream is
> > disabled can be retrieved.
> >
> > v2: Update tail pointer after disable (Umesh)
> >
> > Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> > ---
> >  drivers/gpu/drm/xe/xe_oa.c | 7 +++++--
> >  1 file changed, 5 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/xe/xe_oa.c b/drivers/gpu/drm/xe/xe_oa.c index
> > dcd393b0931a2..2efc16c3a95df 100644
> > --- a/drivers/gpu/drm/xe/xe_oa.c
> > +++ b/drivers/gpu/drm/xe/xe_oa.c
> > @@ -543,8 +543,7 @@ static ssize_t xe_oa_read(struct file *file, char __user
> > *buf,
> >	size_t offset = 0;
> >	int ret;
> >
> > -	/* Can't read from disabled streams */
> > -	if (!stream->enabled || !stream->sample)
> > +	if (!stream->sample)
> >		return -EINVAL;
> >
> >	if (!(file->f_flags & O_NONBLOCK)) {
> > @@ -1456,6 +1455,10 @@ static void xe_oa_stream_disable(struct
> > xe_oa_stream *stream)
> >
> >	if (stream->sample)
> >		hrtimer_cancel(&stream->poll_check_timer);
> > +
> > +	/* Update stream->oa_buffer.tail to allow any final reports to be read */
> > +	if (xe_oa_buffer_check_unlocked(stream))
> > +		wake_up(&stream->poll_wq);
>
> Reviewed-by: Umesh Nerlige Ramappa<umesh.nerlige.ramappa@intel.com>

Thanks Umesh, just FYI, I added Fixes: as well Cc:stable tags on this and
merged it.

>
> > }
> >
> >  static int xe_oa_enable_preempt_timeslice(struct xe_oa_stream *stream)
> > --
> > 2.48.1
>