Re: [RFC PATCH 3/7] drm/xe/xe_ras: Refactor get_counter() to return response structure

["Mallesh, Koujalagi" <mallesh.koujalagi@intel.com>]

On 02-07-2026 04:44 pm, Badal Nilawar wrote:
> Return the complete response structure from get_counter() instead of
> only the counter value. This allows callers to access additional
> response fields, such as has_info_queue for CPER record building.
>
> Signed-off-by: Badal Nilawar <badal.nilawar@intel.com>
> Assisted-by: Copilot:claude-sonnet-4.6
> ---
>   drivers/gpu/drm/xe/xe_ras.c       | 23 +++++++++++++++--------
>   drivers/gpu/drm/xe/xe_ras_types.h | 10 ++++++++--
>   2 files changed, 23 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_ras.c b/drivers/gpu/drm/xe/xe_ras.c
> index 85b0202467f6..e594d4d3a23f 100644
> --- a/drivers/gpu/drm/xe/xe_ras.c
> +++ b/drivers/gpu/drm/xe/xe_ras.c
> @@ -157,12 +157,12 @@ void xe_ras_counter_threshold_crossed(struct xe_device *xe,
>   	}
>   }
>   
> -static int get_counter(struct xe_device *xe, struct xe_ras_error_class *counter, u32 *value)
> +static int get_counter(struct xe_device *xe, const struct xe_ras_error_class *counter,
> +		       struct xe_ras_get_counter_response *out)
>   {
>   	struct xe_ras_get_counter_response response = {0};
response is not required, we can directly use "out".
>   	struct xe_ras_get_counter_request request = {0};
>   	struct xe_sysctrl_mailbox_command command = {0};
> -	struct xe_ras_error_common *common;
>   	size_t rlen;
>   	int ret;
>   
> @@ -183,12 +183,11 @@ static int get_counter(struct xe_device *xe, struct xe_ras_error_class *counter,
>   		return -EIO;
>   	}
>   
> -	common = &response.counter.common;
> -	*value = response.value;
> -
> -	xe_dbg(xe, "[RAS]: get counter %u for %s %s\n", *value, comp_to_str(common->component),
> -	       sev_to_str(common->severity));
> +	xe_dbg(xe, "[RAS]: get counter value %u for %s %s\n", response.value,
> +	       comp_to_str(response.counter.common.component),
> +	       sev_to_str(response.counter.common.severity));
>   
> +	*out = response;
>   	return 0;
>   }
>   
> @@ -207,12 +206,20 @@ static int get_counter(struct xe_device *xe, struct xe_ras_error_class *counter,
>   int xe_ras_get_counter(struct xe_device *xe, u8 severity, u8 component, u32 *value)
>   {
>   	struct xe_ras_error_class counter = {0};
> +	struct xe_ras_get_counter_response response;
Safe to initialized response = {0}.
> +	int ret;
>   
>   	counter.common.severity = drm_to_xe_ras_severity(severity);
>   	counter.common.component = drm_to_xe_ras_component(component);
>   
>   	guard(xe_pm_runtime)(xe);
> -	return get_counter(xe, &counter, value);
> +
> +	ret = get_counter(xe, &counter, &response);
> +	if (ret)
> +		return ret;
> +
> +	*value = response.counter_value;

counter_value is not member of response. should get compilation error.

Thanks,
-/Mallesh

> +	return 0;
>   }
>   
>   /**
> diff --git a/drivers/gpu/drm/xe/xe_ras_types.h b/drivers/gpu/drm/xe/xe_ras_types.h
> index fc496888b3f8..befdaf297103 100644
> --- a/drivers/gpu/drm/xe/xe_ras_types.h
> +++ b/drivers/gpu/drm/xe/xe_ras_types.h
> @@ -155,8 +155,14 @@ struct xe_ras_get_counter_response {
>   	u64 timestamp;
>   	/** @threshold: Threshold value for the counter */
>   	u32 threshold;
> -	/** @reserved: Reserved  */
> -	u32 reserved[57];
> +	/** @reserved: Reserved for future use */
> +	u32 reserved:9;
> +	/** @has_info_queue: Set if info queue is available */
> +	u32 has_info_queue:1;
> +	/** @reserved1: Reserved for future use */
> +	u32 reserved1:22;
> +	/** @info_queue: Initial info queue data (first chunk) if available */
> +	struct xe_ras_info_queue_response info_queue;
>   } __packed;
>   
>   /**