Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Aravind Iddamsetty <aravind.iddamsetty@linux.intel.com>
To: Raag Jadav <raag.jadav@intel.com>,
	airlied@gmail.com, daniel@ffwll.ch, lucas.demarchi@intel.com,
	thomas.hellstrom@linux.intel.com, rodrigo.vivi@intel.com,
	jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com,
	tursulin@ursulin.net
Cc: intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	dri-devel@lists.freedesktop.org, himal.prasad.ghimiray@intel.com,
	francois.dugast@intel.com, anshuman.gupta@intel.com,
	bellekallu.rajkiran@intel.com, saikishore.konda@intel.com
Subject: Re: [PATCH v3 3/3] drm/i915: Use device wedged event
Date: Mon, 2 Sep 2024 14:22:21 +0530	[thread overview]
Message-ID: <9011dfee-3f69-4d80-90e1-efffc6576740@linux.intel.com> (raw)
In-Reply-To: <20240902074859.2992849-4-raag.jadav@intel.com>


On 02/09/24 13:18, Raag Jadav wrote:
> Now that we have device wedged event supported by DRM core, make use
> of it. With this in place, userspace will be notified of wedged device
> on gt reset failure.
>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> ---
>  drivers/gpu/drm/i915/gt/intel_reset.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/gt/intel_reset.c b/drivers/gpu/drm/i915/gt/intel_reset.c
> index 735cd23a43c6..60d09ec536c4 100644
> --- a/drivers/gpu/drm/i915/gt/intel_reset.c
> +++ b/drivers/gpu/drm/i915/gt/intel_reset.c
> @@ -1409,6 +1409,8 @@ static void intel_gt_reset_global(struct intel_gt *gt,
>  
>  	if (!test_bit(I915_WEDGED, &gt->reset.flags))
>  		kobject_uevent_env(kobj, KOBJ_CHANGE, reset_done_event);
> +	else
> +		drm_dev_wedged(&gt->i915->drm);
>  }
rather than intel_gt_reset_global, __intel_get_set_wedged looks to be
an appropriate place where actually the device is declared wedged and
that would cover all call sites too.

Thanks,
Aravind.
>  
>  /**

  reply	other threads:[~2024-09-02  8:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-02  7:48 [PATCH v3 0/3] Introduce DRM device wedged event Raag Jadav
2024-09-02  7:34 ` ✓ CI.Patch_applied: success for " Patchwork
2024-09-02  7:34 ` ✗ CI.checkpatch: warning " Patchwork
2024-09-02  7:35 ` ✓ CI.KUnit: success " Patchwork
2024-09-02  7:47 ` ✓ CI.Build: " Patchwork
2024-09-02  7:48 ` [PATCH v3 1/3] drm: Introduce " Raag Jadav
2024-09-02  7:51   ` Jani Nikula
2024-09-02  9:14   ` Aravind Iddamsetty
2024-09-03  7:48     ` Raag Jadav
2024-09-02  7:48 ` [PATCH v3 2/3] drm/xe: Use " Raag Jadav
2024-09-02  9:09   ` Aravind Iddamsetty
2024-09-02  7:48 ` [PATCH v3 3/3] drm/i915: " Raag Jadav
2024-09-02  8:52   ` Aravind Iddamsetty [this message]
2024-09-03  7:03     ` Raag Jadav
2024-09-02  7:49 ` ✓ CI.Hooks: success for Introduce DRM " Patchwork
2024-09-02  7:51 ` ✗ CI.checksparse: warning " Patchwork
2024-09-02  8:10 ` ✓ CI.BAT: success " Patchwork
2024-09-02  9:24 ` ✗ CI.FULL: failure " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9011dfee-3f69-4d80-90e1-efffc6576740@linux.intel.com \
    --to=aravind.iddamsetty@linux.intel.com \
    --cc=airlied@gmail.com \
    --cc=anshuman.gupta@intel.com \
    --cc=bellekallu.rajkiran@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=francois.dugast@intel.com \
    --cc=himal.prasad.ghimiray@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=joonas.lahtinen@linux.intel.com \
    --cc=lucas.demarchi@intel.com \
    --cc=raag.jadav@intel.com \
    --cc=rodrigo.vivi@intel.com \
    --cc=saikishore.konda@intel.com \
    --cc=thomas.hellstrom@linux.intel.com \
    --cc=tursulin@ursulin.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox