Re: [PATCH v9 1/2] drm/xe: Remove extra newlines from LRC snapshot dump

["Souza, Jose" <jose.souza@intel.com>]

On Wed, 2026-09-16 at 11:10 -0400, Rodrigo Vivi wrote:
> On Tue, Sep 15, 2026 at 10:48:39AM -0700, Alan Previn wrote:
> > From: Zhanjun Dong <zhanjun.dong@intel.com>
> > 
> > The LRC snapshot printer adds an extra newline before the replay
> > offset and replay length lines. This leaves blank lines in the
> > HWCTX section of the dump.
> > 
> > Remove the stray newlines so the snapshot output remains compact
> > and consistently formatted.
> > 
> > Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
> > Reviewed-by: Julia Filipchuk <julia.filipchuk@intel.com>
> 
> Again, you need to sign-off any patch that you are handling...
> in any kind of touch.
> If you are sending to a mailing list or git committing to a branch
> you need
> to sign it off.
> 
> > ---
> >  drivers/gpu/drm/xe/xe_lrc.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/xe/xe_lrc.c
> > b/drivers/gpu/drm/xe/xe_lrc.c
> > index f1cf1463f1b2..a99c7e044c4a 100644
> > --- a/drivers/gpu/drm/xe/xe_lrc.c
> > +++ b/drivers/gpu/drm/xe/xe_lrc.c
> > @@ -2633,8 +2633,8 @@ void xe_lrc_snapshot_print(struct
> > xe_lrc_snapshot *snapshot, struct drm_printer
> >  	}
> >  
> >  	drm_printf(p, "\n\t[HWCTX].length: 0x%lx\n", snapshot-
> > >lrc_size - LRC_PPHWSP_SIZE);
> > -	drm_printf(p, "\n\t[HWCTX].replay_offset: 0x%lx\n",
> > snapshot->replay_offset);
> > -	drm_printf(p, "\n\t[HWCTX].replay_length: 0x%lx\n",
> > snapshot->replay_size);
> > +	drm_printf(p, "\t[HWCTX].replay_offset: 0x%lx\n",
> > snapshot->replay_offset);
> > +	drm_printf(p, "\t[HWCTX].replay_length: 0x%lx\n",
> > snapshot->replay_size);


Acked-by: José Roberto de Souza <jose.souza@intel.com>

> >  
> >  	drm_puts(p, "\t[HWCTX].data: ");
> >  	for (; i < snapshot->lrc_size; i += sizeof(u32)) {
> > -- 
> > 2.43.0
> >