Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Alan Previn <alan.previn.teres.alexis@intel.com>
Cc: intel-xe@lists.freedesktop.org, julia.filipchuk@intel.com,
	matthew.brost@intel.com, "Zhanjun Dong" <zhanjun.dong@intel.com>,
	"José Roberto de Souza" <jose.souza@intel.com>
Subject: Re: [PATCH v9 1/2] drm/xe: Remove extra newlines from LRC snapshot dump
Date: Wed, 16 Sep 2026 11:10:33 -0400	[thread overview]
Message-ID: <aqqxaYPw0O91VFAx@intel.com> (raw)
In-Reply-To: <20260915174840.531473-5-alan.previn.teres.alexis@intel.com>

On Tue, Sep 15, 2026 at 10:48:39AM -0700, Alan Previn wrote:
> From: Zhanjun Dong <zhanjun.dong@intel.com>
> 
> The LRC snapshot printer adds an extra newline before the replay
> offset and replay length lines. This leaves blank lines in the
> HWCTX section of the dump.
> 
> Remove the stray newlines so the snapshot output remains compact
> and consistently formatted.
> 
> Signed-off-by: Zhanjun Dong <zhanjun.dong@intel.com>
> Reviewed-by: Julia Filipchuk <julia.filipchuk@intel.com>

Again, you need to sign-off any patch that you are handling...
in any kind of touch.
If you are sending to a mailing list or git committing to a branch you need
to sign it off.

> ---
>  drivers/gpu/drm/xe/xe_lrc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_lrc.c b/drivers/gpu/drm/xe/xe_lrc.c
> index f1cf1463f1b2..a99c7e044c4a 100644
> --- a/drivers/gpu/drm/xe/xe_lrc.c
> +++ b/drivers/gpu/drm/xe/xe_lrc.c
> @@ -2633,8 +2633,8 @@ void xe_lrc_snapshot_print(struct xe_lrc_snapshot *snapshot, struct drm_printer
>  	}
>  
>  	drm_printf(p, "\n\t[HWCTX].length: 0x%lx\n", snapshot->lrc_size - LRC_PPHWSP_SIZE);
> -	drm_printf(p, "\n\t[HWCTX].replay_offset: 0x%lx\n", snapshot->replay_offset);
> -	drm_printf(p, "\n\t[HWCTX].replay_length: 0x%lx\n", snapshot->replay_size);
> +	drm_printf(p, "\t[HWCTX].replay_offset: 0x%lx\n", snapshot->replay_offset);
> +	drm_printf(p, "\t[HWCTX].replay_length: 0x%lx\n", snapshot->replay_size);
>  
>  	drm_puts(p, "\t[HWCTX].data: ");
>  	for (; i < snapshot->lrc_size; i += sizeof(u32)) {
> -- 
> 2.43.0
> 

  reply	other threads:[~2026-09-16 15:10 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15 17:48 [PATCH v9 0/2] drm/xe/guc: Compress GuC log and CTB dump with zstd Alan Previn
2026-09-15 17:48 ` [PATCH v9 1/2] drm/xe: Remove extra newlines from LRC snapshot dump Alan Previn
2026-09-16 15:10   ` Rodrigo Vivi [this message]
2026-09-16 15:14     ` Souza, Jose
2026-09-15 17:48 ` [PATCH v9 2/2] drm/xe/guc: Compress GuC log and CTB dump with zstd Alan Previn
2026-09-15 18:00   ` sashiko-bot
2026-09-16 15:38   ` Rodrigo Vivi
2026-09-16 20:18     ` Teres Alexis, Alan Previn
2026-09-16 21:24   ` Julia Filipchuk
2026-09-16 21:28     ` Teres Alexis, Alan Previn
2026-09-15 18:10 ` ✗ CI.checkpatch: warning for drm/xe/guc: Compress GuC log and CTB dump with zstd (rev5) Patchwork
2026-09-15 18:13 ` ✓ CI.KUnit: success " Patchwork
2026-09-15 19:07 ` ✓ Xe.CI.BAT: " Patchwork
2026-09-16  1:17 ` ✓ Xe.CI.FULL: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aqqxaYPw0O91VFAx@intel.com \
    --to=rodrigo.vivi@intel.com \
    --cc=alan.previn.teres.alexis@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jose.souza@intel.com \
    --cc=julia.filipchuk@intel.com \
    --cc=matthew.brost@intel.com \
    --cc=zhanjun.dong@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox