From: Jani Nikula <jani.nikula@intel.com>
To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org
Cc: "Lucas De Marchi" <lucas.demarchi@intel.com>,
"Rodrigo Vivi" <rodrigo.vivi@intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: Re: [RFC] drm/i915: move i915 specific display adaptation files to display-adapt
Date: Tue, 25 Nov 2025 16:01:11 +0200 [thread overview]
Message-ID: <929e694adba1e3942c685826906bd8123a1696d3@intel.com> (raw)
In-Reply-To: <20251015160140.2296120-1-jani.nikula@intel.com>
On Wed, 15 Oct 2025, Jani Nikula <jani.nikula@intel.com> wrote:
> The display/ subdirectory currently contains files that are about i915
> core driver adaptation to display rather than generic display
> implementation. Move them to a new i915 subdirectory display-adapt/.
>
> In the xe driver, all of its display/ is basically xe core adaptation to
> display. It's just that i915 display/ contains the actual display
> implementation for both. Ideally, we'd have the shared display code
> somewhere else, and the adaptation in i915 would be under display/, but
> we're not quite ready for that kind of churn yet. So let's just call it
> display-adapt for now.
>
> xe basically has equivalent files to the ones that are being moved,
> apart from intel_dpt.c, for which the implementation is quite different.
>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/Makefile | 23 +++++++++++--------
> .../{display => display-adapt}/intel_bo.c | 3 ++-
> .../intel_display_rpm.c | 5 ++--
> .../{display => display-adapt}/intel_dpt.c | 11 +++++----
> .../intel_dsb_buffer.c | 5 ++--
> .../{display => display-adapt}/intel_fb_bo.c | 9 ++++----
> .../{display => display-adapt}/intel_fb_pin.c | 14 +++++------
> .../intel_fbdev_fb.c | 5 +++-
> .../intel_hdcp_gsc.c | 2 +-
> .../{display => display-adapt}/intel_panic.c | 6 ++---
> .../intel_plane_initial.c | 17 +++++++-------
> 11 files changed, 56 insertions(+), 44 deletions(-)
> rename drivers/gpu/drm/i915/{display => display-adapt}/intel_bo.c (98%)
> rename drivers/gpu/drm/i915/{display => display-adapt}/intel_display_rpm.c (95%)
> rename drivers/gpu/drm/i915/{display => display-adapt}/intel_dpt.c (97%)
> rename drivers/gpu/drm/i915/{display => display-adapt}/intel_dsb_buffer.c (96%)
> rename drivers/gpu/drm/i915/{display => display-adapt}/intel_fb_bo.c (94%)
> rename drivers/gpu/drm/i915/{display => display-adapt}/intel_fb_pin.c (97%)
> rename drivers/gpu/drm/i915/{display => display-adapt}/intel_fbdev_fb.c (94%)
> rename drivers/gpu/drm/i915/{display => display-adapt}/intel_hdcp_gsc.c (99%)
> rename drivers/gpu/drm/i915/{display => display-adapt}/intel_panic.c (84%)
> rename drivers/gpu/drm/i915/{display => display-adapt}/intel_plane_initial.c (97%)
I've been postponing the series pending other refactoring.
Anyway, Ville, are you okay with moving intel_dpt.c to i915? Doesn't
that reflect the reality with i915 and xe implementations?
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2025-11-25 14:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-15 16:01 [RFC] drm/i915: move i915 specific display adaptation files to display-adapt Jani Nikula
2025-10-16 1:05 ` ✗ CI.checkpatch: warning for " Patchwork
2025-10-16 1:06 ` ✓ CI.KUnit: success " Patchwork
2025-10-16 1:45 ` ✓ Xe.CI.BAT: " Patchwork
2025-10-16 19:04 ` ✓ Xe.CI.Full: " Patchwork
2025-10-16 19:42 ` [RFC] " Rodrigo Vivi
2025-10-21 9:00 ` Jani Nikula
2025-10-21 15:03 ` Rodrigo Vivi
2025-11-25 14:01 ` Jani Nikula [this message]
2025-11-25 17:30 ` Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=929e694adba1e3942c685826906bd8123a1696d3@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=lucas.demarchi@intel.com \
--cc=rodrigo.vivi@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox