From: Jani Nikula <jani.nikula@intel.com>
To: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>,
intel-xe@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Cc: "Juha-Pekka Heikkila" <juhapekka.heikkila@gmail.com>,
"Tvrtko Ursulin" <tvrtko.ursulin@igalia.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v2] drm/i915/display: enable ccs modifiers on dg2
Date: Fri, 24 Apr 2026 11:44:57 +0300 [thread overview]
Message-ID: <92d121173a3e42ef91274f9fa810e47d71b8dd70@intel.com> (raw)
In-Reply-To: <20260423141148.3145665-1-juhapekka.heikkila@gmail.com>
On Thu, 23 Apr 2026, Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com> wrote:
> Since Xe driver aux ccs enablement dg2 ccs modifiers have been
> disabled on both Xe and i915 drivers. Here allow dg2 to use
> ccs again for framebuffers.
>
> Fixes: 6a99e91a6ca8fec5882450128fb128265f86b32a ("drm/i915/display: Detect AuxCCS support via display parent interface")
In kernel, there should be 12 characters of sha1.
'dim fixes <sha1>' gives you the correct format, and suggests Cc's
(though you probably shouldn't actually Cc all of them).
For referencing commits in general, I have this handy alias in my
.gitconfig:
[alias]
cite = log -1 --abbrev=12 '--format=%h (\"%s\")'
$ git cite 6a99e91a6ca8fec5882450128fb128265f86b32a
6a99e91a6ca8 ("drm/i915/display: Detect AuxCCS support via display parent interface")
BR,
Jani.
> Signed-off-by: Juha-Pekka Heikkila <juhapekka.heikkila@gmail.com>
> ---
> drivers/gpu/drm/i915/i915_driver.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_driver.c b/drivers/gpu/drm/i915/i915_driver.c
> index d31819758f3d..a4bd4f8e18b2 100644
> --- a/drivers/gpu/drm/i915/i915_driver.c
> +++ b/drivers/gpu/drm/i915/i915_driver.c
> @@ -750,9 +750,8 @@ static bool has_auxccs(struct drm_device *drm)
> {
> struct drm_i915_private *i915 = to_i915(drm);
>
> - return IS_GRAPHICS_VER(i915, 9, 12) ||
> - IS_ALDERLAKE_P(i915) ||
> - IS_METEORLAKE(i915);
> + return IS_GRAPHICS_VER(i915, 9, 12) &&
> + !HAS_FLAT_CCS(i915);
> }
>
> static bool has_fenced_regions(struct drm_device *drm)
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-04-24 8:45 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 14:11 [PATCH v2] drm/i915/display: enable ccs modifiers on dg2 Juha-Pekka Heikkila
2026-04-23 14:19 ` ✓ CI.KUnit: success for drm/i915/display: enable ccs modifiers on dg2 (rev2) Patchwork
2026-04-23 15:28 ` ✓ Xe.CI.BAT: " Patchwork
2026-04-23 18:57 ` [PATCH v2] drm/i915/display: enable ccs modifiers on dg2 Ville Syrjälä
2026-04-23 20:24 ` Matt Roper
2026-04-24 0:08 ` ✗ Xe.CI.FULL: failure for drm/i915/display: enable ccs modifiers on dg2 (rev2) Patchwork
2026-04-24 8:44 ` Jani Nikula [this message]
2026-04-24 11:42 ` [PATCH v2] drm/i915/display: enable ccs modifiers on dg2 Raag Jadav
2026-04-24 11:53 ` Juha-Pekka Heikkilä
2026-04-24 12:23 ` Jani Nikula
-- strict thread matches above, loose matches on Subject: below --
2026-04-27 16:57 Juha-Pekka Heikkila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=92d121173a3e42ef91274f9fa810e47d71b8dd70@intel.com \
--to=jani.nikula@intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=juhapekka.heikkila@gmail.com \
--cc=tvrtko.ursulin@igalia.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox