Re: [PATCH v4 08/11] drm/xe/configfs: Keep default device config settings together

[John Harrison <john.c.harrison@intel.com>]

On 7/27/2025 10:20 AM, Michal Wajdeczko wrote:
> For easier maintenance add a placeholder where we can keep all
> default device configuration settings in one place.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Reviewed-by: John Harrison <John.C.Harrison@Intel.com>

> ---
>   drivers/gpu/drm/xe/xe_configfs.c | 17 +++++++++++++----
>   1 file changed, 13 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/xe/xe_configfs.c b/drivers/gpu/drm/xe/xe_configfs.c
> index a5f13dd779c7..60d89d3ef656 100644
> --- a/drivers/gpu/drm/xe/xe_configfs.c
> +++ b/drivers/gpu/drm/xe/xe_configfs.c
> @@ -98,6 +98,16 @@ struct xe_config_group_device {
>   	} config;
>   };
>   
> +static struct xe_config_device device_defaults = {
> +	.survivability_mode = false,
> +	.engines_allowed = U64_MAX,
> +};
> +
> +static void set_device_defaults(struct xe_config_device *config)
> +{
> +	*config = device_defaults;
> +}
> +
>   struct engine_info {
>   	const char *cls;
>   	u64 mask;
> @@ -286,8 +296,7 @@ static struct config_group *xe_config_make_device_group(struct config_group *gro
>   	if (!dev)
>   		return ERR_PTR(-ENOMEM);
>   
> -	/* Default values */
> -	dev->config.engines_allowed = U64_MAX;
> +	set_device_defaults(&dev->config);
>   
>   	config_group_init_type_name(&dev->group, name, &xe_config_device_type);
>   
> @@ -339,7 +348,7 @@ bool xe_configfs_get_survivability_mode(struct pci_dev *pdev)
>   	bool mode;
>   
>   	if (!dev)
> -		return false;
> +		return device_defaults.survivability_mode;
>   
>   	mode = dev->config.survivability_mode;
>   	config_group_put(&dev->group);
> @@ -382,7 +391,7 @@ u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev)
>   	u64 engines_allowed;
>   
>   	if (!dev)
> -		return U64_MAX;
> +		return device_defaults.engines_allowed;
>   
>   	engines_allowed = dev->config.engines_allowed;
>   	config_group_put(&dev->group);