Re: [PATCH v4 06/11] drm/xe/configfs: Rename configfs_find_group() helper

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Sun, Jul 27, 2025 at 07:20:03PM +0200, Michal Wajdeczko wrote:
> This helper name shouldn't suggest that it iss a part of the core
> configfs API family. While around switch to use different helper
> to release a reference.
> 
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Cc: Lucas De Marchi <lucas.demarchi@intel.com>

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

> ---
>  drivers/gpu/drm/xe/xe_configfs.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_configfs.c b/drivers/gpu/drm/xe/xe_configfs.c
> index edd52b8f0543..f5a780b8bb80 100644
> --- a/drivers/gpu/drm/xe/xe_configfs.c
> +++ b/drivers/gpu/drm/xe/xe_configfs.c
> @@ -305,7 +305,7 @@ static struct configfs_subsystem xe_configfs = {
>  	},
>  };
>  
> -static struct xe_config_group_device *configfs_find_group(struct pci_dev *pdev)
> +static struct xe_config_group_device *find_xe_config_group_device(struct pci_dev *pdev)
>  {
>  	guard(mutex)(&xe_configfs.su_mutex);
>  	struct config_item *item;
> @@ -328,14 +328,14 @@ static struct xe_config_group_device *configfs_find_group(struct pci_dev *pdev)
>   */
>  bool xe_configfs_get_survivability_mode(struct pci_dev *pdev)
>  {
> -	struct xe_config_group_device *dev = configfs_find_group(pdev);
> +	struct xe_config_group_device *dev = find_xe_config_group_device(pdev);
>  	bool mode;
>  
>  	if (!dev)
>  		return false;
>  
>  	mode = dev->survivability_mode;
> -	config_item_put(&dev->group.cg_item);
> +	config_group_put(&dev->group);
>  
>  	return mode;
>  }
> @@ -349,7 +349,7 @@ bool xe_configfs_get_survivability_mode(struct pci_dev *pdev)
>   */
>  void xe_configfs_clear_survivability_mode(struct pci_dev *pdev)
>  {
> -	struct xe_config_group_device *dev = configfs_find_group(pdev);
> +	struct xe_config_group_device *dev = find_xe_config_group_device(pdev);
>  
>  	if (!dev)
>  		return;
> @@ -357,7 +357,7 @@ void xe_configfs_clear_survivability_mode(struct pci_dev *pdev)
>  	scoped_guard(mutex, &xe_configfs.su_mutex)
>  		dev->survivability_mode = 0;
>  
> -	config_item_put(&dev->group.cg_item);
> +	config_group_put(&dev->group);
>  }
>  
>  /**
> @@ -371,14 +371,14 @@ void xe_configfs_clear_survivability_mode(struct pci_dev *pdev)
>   */
>  u64 xe_configfs_get_engines_allowed(struct pci_dev *pdev)
>  {
> -	struct xe_config_group_device *dev = configfs_find_group(pdev);
> +	struct xe_config_group_device *dev = find_xe_config_group_device(pdev);
>  	u64 engines_allowed;
>  
>  	if (!dev)
>  		return U64_MAX;
>  
>  	engines_allowed = dev->engines_allowed;
> -	config_item_put(&dev->group.cg_item);
> +	config_group_put(&dev->group);
>  
>  	return engines_allowed;
>  }
> -- 
> 2.47.1
>