Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 1/2] drm/xe: fix WA 14018094691
@ 2024-08-07 23:53 Daniele Ceraolo Spurio
  2024-08-07 23:53 ` [PATCH v2 2/2] drm/xe/bmg: extend WA 14018094691 to BMG Daniele Ceraolo Spurio
                   ` (10 more replies)
  0 siblings, 11 replies; 14+ messages in thread
From: Daniele Ceraolo Spurio @ 2024-08-07 23:53 UTC (permalink / raw)
  To: intel-xe; +Cc: Daniele Ceraolo Spurio, Matt Roper, Lucas De Marchi

This WA is applied while initializing the media GT, but it a primary
GT WA (because it modifies a register on the primary GT), so the XE_WA
macro is returning false even when the WA should be applied.
Fix this by using the primary GT in the macro.

Note that this WA only applies to PXP and we don't yet support that in
Xe, so there are no negative effects to this bug, which is why we didn't
see any errors in testing.

v2: use the primary GT in the macro instead of marking the WA as
platform-wide (Lucas, Matt).

Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
Cc: Matt Roper <matthew.d.roper@intel.com>
Cc: Lucas De Marchi <lucas.demarchi@intel.com>
---
 drivers/gpu/drm/xe/xe_gsc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/gpu/drm/xe/xe_gsc.c b/drivers/gpu/drm/xe/xe_gsc.c
index f8239a13fa2b..77ce44e845c5 100644
--- a/drivers/gpu/drm/xe/xe_gsc.c
+++ b/drivers/gpu/drm/xe/xe_gsc.c
@@ -260,7 +260,7 @@ static int gsc_upload_and_init(struct xe_gsc *gsc)
 	struct xe_tile *tile = gt_to_tile(gt);
 	int ret;
 
-	if (XE_WA(gt, 14018094691)) {
+	if (XE_WA(tile->primary_gt, 14018094691)) {
 		ret = xe_force_wake_get(gt_to_fw(tile->primary_gt), XE_FORCEWAKE_ALL);
 
 		/*
@@ -278,7 +278,7 @@ static int gsc_upload_and_init(struct xe_gsc *gsc)
 
 	ret = gsc_upload(gsc);
 
-	if (XE_WA(gt, 14018094691))
+	if (XE_WA(tile->primary_gt, 14018094691))
 		xe_force_wake_put(gt_to_fw(tile->primary_gt), XE_FORCEWAKE_ALL);
 
 	if (ret)
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 14+ messages in thread

end of thread, other threads:[~2024-08-08 17:01 UTC | newest]

Thread overview: 14+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-07 23:53 [PATCH v2 1/2] drm/xe: fix WA 14018094691 Daniele Ceraolo Spurio
2024-08-07 23:53 ` [PATCH v2 2/2] drm/xe/bmg: extend WA 14018094691 to BMG Daniele Ceraolo Spurio
2024-08-07 23:56   ` Matt Roper
2024-08-08 17:01     ` Daniele Ceraolo Spurio
2024-08-07 23:56 ` [PATCH v2 1/2] drm/xe: fix WA 14018094691 Matt Roper
2024-08-07 23:58 ` ✓ CI.Patch_applied: success for series starting with [v2,1/2] " Patchwork
2024-08-07 23:58 ` ✓ CI.checkpatch: " Patchwork
2024-08-08  0:00 ` ✓ CI.KUnit: " Patchwork
2024-08-08  0:11 ` ✓ CI.Build: " Patchwork
2024-08-08  0:14 ` ✓ CI.Hooks: " Patchwork
2024-08-08  0:15 ` ✓ CI.checksparse: " Patchwork
2024-08-08  0:35 ` ✓ CI.BAT: " Patchwork
2024-08-08  1:35 ` ✗ CI.FULL: failure " Patchwork
2024-08-08  6:47 ` [PATCH v2 1/2] " Lucas De Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox