Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Nilawar, Badal" <badal.nilawar@intel.com>
To: Vinay Belgaumkar <vinay.belgaumkar@intel.com>,
	<intel-xe@lists.freedesktop.org>
Subject: Re: [PATCH 1/2] drm/xe: Add GSC to powergate_info
Date: Fri, 30 Jan 2026 20:53:35 +0530	[thread overview]
Message-ID: <9c9e4054-cf75-42a2-9dda-3d4073f5160c@intel.com> (raw)
In-Reply-To: <20260115224040.2668209-2-vinay.belgaumkar@intel.com>


On 16-01-2026 04:10, Vinay Belgaumkar wrote:
> Add GSC powergate status to the existing debugfs.
>
> Signed-off-by: Vinay Belgaumkar <vinay.belgaumkar@intel.com>
> ---
>   drivers/gpu/drm/xe/regs/xe_gt_regs.h | 1 +
>   drivers/gpu/drm/xe/xe_gt_idle.c      | 5 +++++
>   2 files changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/xe/regs/xe_gt_regs.h b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> index 24fc64fc832e..7d3ec1fe4f7f 100644
> --- a/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> +++ b/drivers/gpu/drm/xe/regs/xe_gt_regs.h
> @@ -367,6 +367,7 @@
>   #define FORCEWAKE_RENDER			XE_REG(0xa278)
>   
>   #define POWERGATE_DOMAIN_STATUS			XE_REG(0xa2a0)
> +#define   GSC_AWAKE_STATUS			REG_BIT(8)
>   #define   MEDIA_SLICE3_AWAKE_STATUS		REG_BIT(4)
>   #define   MEDIA_SLICE2_AWAKE_STATUS		REG_BIT(3)
>   #define   MEDIA_SLICE1_AWAKE_STATUS		REG_BIT(2)
> diff --git a/drivers/gpu/drm/xe/xe_gt_idle.c b/drivers/gpu/drm/xe/xe_gt_idle.c
> index c1c9bec3c487..52436dcb6381 100644
> --- a/drivers/gpu/drm/xe/xe_gt_idle.c
> +++ b/drivers/gpu/drm/xe/xe_gt_idle.c
> @@ -255,6 +255,11 @@ int xe_gt_idle_pg_print(struct xe_gt *gt, struct drm_printer *p)
>   		drm_printf(p, "Media Samplers Power Gating Enabled: %s\n",
>   			   str_yes_no(pg_enabled & MEDIA_SAMPLERS_POWERGATE_ENABLE));
>   
> +	if (gt->info.engine_mask & BIT(XE_HW_ENGINE_GSCCS0)) {
> +		drm_printf(p, "GSC Power Gate Status: %s\n",
> +			   str_up_down(pg_status & GSC_AWAKE_STATUS));
> +	}
> +

Looks good to me.
Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>

Thanks,
Badal

>   	return 0;
>   }
>   

  reply	other threads:[~2026-01-30 15:23 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-15 22:40 [PATCH 0/2] drm/xe: Add more info to powergate_info debugfs Vinay Belgaumkar
2026-01-15 22:40 ` [PATCH 1/2] drm/xe: Add GSC to powergate_info Vinay Belgaumkar
2026-01-30 15:23   ` Nilawar, Badal [this message]
2026-01-15 22:40 ` [PATCH 2/2] drm/xe: Add forcewake status " Vinay Belgaumkar
2026-01-30 15:20   ` Nilawar, Badal
2026-01-30 17:34     ` Belgaumkar, Vinay
2026-02-02  6:38       ` Nilawar, Badal
2026-02-02 17:12         ` Belgaumkar, Vinay
2026-02-02 17:20           ` Nilawar, Badal
2026-02-03  6:07             ` Nilawar, Badal
2026-01-15 22:48 ` ✗ CI.checkpatch: warning for drm/xe: Add more info to powergate_info debugfs Patchwork
2026-01-15 22:50 ` ✓ CI.KUnit: success " Patchwork
2026-01-15 23:36 ` ✗ Xe.CI.BAT: failure " Patchwork
2026-01-16  4:34 ` ✗ Xe.CI.Full: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c9e4054-cf75-42a2-9dda-3d4073f5160c@intel.com \
    --to=badal.nilawar@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=vinay.belgaumkar@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox